public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
@ 2014-04-26 22:12 poma
  2014-05-06  2:46 ` poma
  0 siblings, 1 reply; 10+ messages in thread
From: poma @ 2014-04-26 22:12 UTC (permalink / raw)
  To: linux-kernel; +Cc: poma, kernel, andreas.utterberg, jwboyer, sgruszka

Need to set wapf to 4 for ASUSTeK COMPUTER INC. X75VBP & X550CA, so that the wireless network adapter is enabled.

References:
- asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP
http://marc.info/?l=linux-kernel&m=139819918125110
- Ath9k WiFi now disabled by radio killswitch
https://bugzilla.redhat.com/show_bug.cgi?id=1089731

Reported-by: poma <pomidorabelisima@gmail.com>
Reported-by: Andreas Utterberg <andreas.utterberg@thundera.se>
Tested-by: poma <pomidorabelisima@gmail.com>
Tested-by: Andreas Utterberg <andreas.utterberg@thundera.se>
Cc: Fedora kernel development <kernel@lists.fedoraproject.org>
Cc: Andreas Utterberg <andreas.utterberg@thundera.se>
Cc: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>

---
 drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 563f59e..d3641e0 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -137,6 +137,15 @@ static struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X550CA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X550CA"),
+		},
+		.driver_data = &quirk_asus_x401u,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. X55A",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
@@ -182,6 +191,15 @@ static struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X75VBP",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X75VBP"),
+		},
+		.driver_data = &quirk_asus_x401u,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. 1015E",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
1.9.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-04-26 22:12 [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA poma
@ 2014-05-06  2:46 ` poma
  2014-05-06 14:45   ` poma
  0 siblings, 1 reply; 10+ messages in thread
From: poma @ 2014-05-06  2:46 UTC (permalink / raw)
  To: Corentin Chary, Corentin Chary,
	platform-driver-x86@vger.kernel.org
  Cc: linux-kernel, kernel, andreas.utterberg, jwboyer, sgruszka

On 27.04.2014 00:12, poma wrote:
> Need to set wapf to 4 for ASUSTeK COMPUTER INC. X75VBP & X550CA, so that the wireless network adapter is enabled.
> 
> References:
> - asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP
> http://marc.info/?l=linux-kernel&m=139819918125110
> - Ath9k WiFi now disabled by radio killswitch
> https://bugzilla.redhat.com/show_bug.cgi?id=1089731
> 
> Reported-by: poma <pomidorabelisima@gmail.com>
> Reported-by: Andreas Utterberg <andreas.utterberg@thundera.se>
> Tested-by: poma <pomidorabelisima@gmail.com>
> Tested-by: Andreas Utterberg <andreas.utterberg@thundera.se>
> Cc: Fedora kernel development <kernel@lists.fedoraproject.org>
> Cc: Andreas Utterberg <andreas.utterberg@thundera.se>
> Cc: Josh Boyer <jwboyer@fedoraproject.org>
> Cc: Stanislaw Gruszka <sgruszka@redhat.com>
> 
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 563f59e..d3641e0 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -137,6 +137,15 @@ static struct dmi_system_id asus_quirks[] = {
>  	},
>  	{
>  		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X550CA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X550CA"),
> +		},
> +		.driver_data = &quirk_asus_x401u,
> +	},
> +	{
> +		.callback = dmi_matched,
>  		.ident = "ASUSTeK COMPUTER INC. X55A",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> @@ -182,6 +191,15 @@ static struct dmi_system_id asus_quirks[] = {
>  	},
>  	{
>  		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X75VBP",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X75VBP"),
> +		},
> +		.driver_data = &quirk_asus_x401u,
> +	},
> +	{
> +		.callback = dmi_matched,
>  		.ident = "ASUSTeK COMPUTER INC. 1015E",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> 

Corentin, care to pick up this one?
https://bugzilla.redhat.com/attachment.cgi?id=892751


poma





^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06  2:46 ` poma
@ 2014-05-06 14:45   ` poma
  2014-05-06 14:48     ` Matthew Garrett
  0 siblings, 1 reply; 10+ messages in thread
From: poma @ 2014-05-06 14:45 UTC (permalink / raw)
  To: platform-driver-x86@vger.kernel.org, Matthew Garrett
  Cc: Corentin Chary, Corentin Chary, linux-kernel, kernel,
	andreas.utterberg, jwboyer, sgruszka


> Corentin, care to pick up this one?
> https://bugzilla.redhat.com/attachment.cgi?id=892751

Matthew, who actually maintains the Asus Notebooks WMI Hotkey Driver i.e. 'asus-nb-wmi'?


poma



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06 14:45   ` poma
@ 2014-05-06 14:48     ` Matthew Garrett
  2014-05-06 20:17       ` poma
  0 siblings, 1 reply; 10+ messages in thread
From: Matthew Garrett @ 2014-05-06 14:48 UTC (permalink / raw)
  To: poma
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

That's not being merged without a Signed-off-by:.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06 14:48     ` Matthew Garrett
@ 2014-05-06 20:17       ` poma
  2014-05-06 20:55         ` Matthew Garrett
  0 siblings, 1 reply; 10+ messages in thread
From: poma @ 2014-05-06 20:17 UTC (permalink / raw)
  To: Matthew Garrett
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]




[-- Attachment #2: 0001-WAPF-4-for-ASUSTeK-COMPUTER-INC.-X75VBP-WLAN-ON.patch --]
[-- Type: text/x-patch, Size: 1021 bytes --]

>From d39d3460f1ab36365a48b6815dd9a5d26613d3ec Mon Sep 17 00:00:00 2001
From: poma <pomidorabelisima@gmail.com>
Date: Tue, 6 May 2014 22:03:38 +0200
Subject: [PATCH] WAPF 4 for ASUSTeK COMPUTER INC. X75VBP WLAN ON.

Signed-off-by: poma <pomidorabelisima@gmail.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 563f59e..674793d 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -182,6 +182,15 @@ static struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X75VBP",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X75VBP"),
+		},
+		.driver_data = &quirk_asus_x401u,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. 1015E",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
1.9.0




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06 20:17       ` poma
@ 2014-05-06 20:55         ` Matthew Garrett
  2014-05-06 21:29           ` poma
  0 siblings, 1 reply; 10+ messages in thread
From: Matthew Garrett @ 2014-05-06 20:55 UTC (permalink / raw)
  To: poma
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

Could you include a description in the patch for why this is necessary?
-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06 20:55         ` Matthew Garrett
@ 2014-05-06 21:29           ` poma
  2014-05-06 21:42             ` Matthew Garrett
  0 siblings, 1 reply; 10+ messages in thread
From: poma @ 2014-05-06 21:29 UTC (permalink / raw)
  To: Matthew Garrett
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]




[-- Attachment #2: 0001-WAPF-4-for-ASUSTeK-COMPUTER-INC.-X75VBP-WLAN-ON.patch --]
[-- Type: text/x-patch, Size: 1124 bytes --]

>From d39d3460f1ab36365a48b6815dd9a5d26613d3ec Mon Sep 17 00:00:00 2001
From: poma <pomidorabelisima@gmail.com>
Date: Tue, 6 May 2014 22:03:38 +0200
Subject: [PATCH] WAPF 4 for ASUSTeK COMPUTER INC. X75VBP WLAN ON.

The 'asus-nb-wmi' WAPF parameter must be set to 4, so the internal Wireless LAN device is operational.

Signed-off-by: poma <pomidorabelisima@gmail.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 563f59e..674793d 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -182,6 +182,15 @@ static struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X75VBP",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X75VBP"),
+		},
+		.driver_data = &quirk_asus_x401u,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. 1015E",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
1.9.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06 21:29           ` poma
@ 2014-05-06 21:42             ` Matthew Garrett
  2014-06-11  1:03               ` poma
  0 siblings, 1 reply; 10+ messages in thread
From: Matthew Garrett @ 2014-05-06 21:42 UTC (permalink / raw)
  To: poma
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

Thanks, if there are no objections I'll apply that.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-05-06 21:42             ` Matthew Garrett
@ 2014-06-11  1:03               ` poma
  2014-06-11  1:24                 ` Matthew Garrett
  0 siblings, 1 reply; 10+ messages in thread
From: poma @ 2014-06-11  1:03 UTC (permalink / raw)
  To: Matthew Garrett
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

On 06.05.2014 23:42, Matthew Garrett wrote:
> Thanks, if there are no objections I'll apply that.
>

Matthew, any info for X75VBP?


poma



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA
  2014-06-11  1:03               ` poma
@ 2014-06-11  1:24                 ` Matthew Garrett
  0 siblings, 0 replies; 10+ messages in thread
From: Matthew Garrett @ 2014-06-11  1:24 UTC (permalink / raw)
  To: poma
  Cc: platform-driver-x86@vger.kernel.org, Corentin Chary,
	Corentin Chary, linux-kernel, kernel, andreas.utterberg, jwboyer,
	sgruszka

Hm. Sorry, I thought I'd picked that one up. I'll send it in a couple of 
days.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-06-11  1:24 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-26 22:12 [PATCH] asus-nb-wmi: set wapf=4 for ASUSTeK COMPUTER INC. X75VBP & X550CA poma
2014-05-06  2:46 ` poma
2014-05-06 14:45   ` poma
2014-05-06 14:48     ` Matthew Garrett
2014-05-06 20:17       ` poma
2014-05-06 20:55         ` Matthew Garrett
2014-05-06 21:29           ` poma
2014-05-06 21:42             ` Matthew Garrett
2014-06-11  1:03               ` poma
2014-06-11  1:24                 ` Matthew Garrett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox