From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932681AbaEGMRu (ORCPT ); Wed, 7 May 2014 08:17:50 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:59419 "EHLO mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbaEGMRs (ORCPT ); Wed, 7 May 2014 08:17:48 -0400 Date: Wed, 7 May 2014 14:17:43 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Rik van Riel , Preeti Murthy , umgwanakikbuti@gmail.com, LKML , Morten Rasmussen , george.mccollister@gmail.com, ktkhai@parallels.com, Preeti U Murthy Subject: Re: [PATCH RFC/TEST] sched: make sync affine wakeups work Message-ID: <20140507121743.GA12190@gmail.com> References: <20140502004237.79dd3de6@annuminas.surriel.com> <1399011219.5233.55.camel@marge.simpson.net> <53633B81.1080403@redhat.com> <53663565.9080306@redhat.com> <20140506132516.GJ11096@twins.programming.kicks-ass.net> <5369442B.9010505@redhat.com> <20140506204117.GR17778@laptop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140506204117.GR17778@laptop.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Tue, May 06, 2014 at 04:20:59PM -0400, Rik van Riel wrote: > > On 05/06/2014 09:25 AM, Peter Zijlstra wrote: > > > On Sun, May 04, 2014 at 08:41:09AM -0400, Rik van Riel wrote: > > >> Even on 8-node DL980 systems, the NUMA distance in the > > >> SLIT table is less than RECLAIM_DISTANCE, and we will > > >> do wake_affine across the entire system. > > > > > > Yeah, so the problem is that (AFAIK) ACPI doesn't actually specify a > > > metric for the SLIT distance. This (in as far as BIOS people would care > > > to stick to specs anyhow) has lead to the 'fun' situation where BIOS > > > engineers tweak SLIT table values to make OSes behave as they thing it > > > should. > > > > > > So if the BIOS engineer finds that this system should have < > > > RECLAIM_DISTANCE it will simply make the table such that the max SLIT > > > value is below that. > > > > > > And yes, I've seen this :-( > > > > It appears to be the case on the vast majority of the NUMA systems > > that are actually in use. > > > > To me, this suggests that we should probably deal with it. > > What we could do is redefine this distance in hops, that'll force > them to lie more blatantly and actually miss represent the topology. and we should make sure we reduce any graph they represent, so that they can lie only through very heavy misrepresentation of the topology (i.e. not just weight tweaks) which will bite them in other areas (like the mm). Thanks, Ingo