From: John Church <sleeveroller@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
georgiana.chelu93@gmail.com, waydi1@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c
Date: Wed, 7 May 2014 13:51:07 +0100 [thread overview]
Message-ID: <20140507125107.GA9345@waldorf-new> (raw)
In-Reply-To: <20140507123915.GA26890@mwanda>
On Wed, May 07, 2014 at 03:39:15PM +0300, Dan Carpenter wrote:
> I wonder if there is some kind of tutorial which teaches people to
> choose the least specific subject possible? We should find which
> tutorial it is and update it. John, can you give us a hint here which
> tutorial you are using?
I'm doing the Eudyptula Challenge. Task 10 is to fix a coding style issue and submit it the relevant maintainers.
>
> On Wed, May 07, 2014 at 01:30:02PM +0100, John Church wrote:
> > This patch fixes a coding style issue for a line that was over 80 characters long.
> >
> > Signed-off-by: John Church <sleeveroller@gmail.com>
>
> Anyway, looks ok.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
Thanks for your advice Dan. I've setup git send-email and mutt now so I could test the patch properly before sending.
Regards,
John
prev parent reply other threads:[~2014-05-07 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 12:30 [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c John Church
2014-05-07 12:39 ` Dan Carpenter
2014-05-07 12:51 ` John Church [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507125107.GA9345@waldorf-new \
--to=sleeveroller@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=georgiana.chelu93@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=waydi1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox