From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932885AbaEGMzl (ORCPT ); Wed, 7 May 2014 08:55:41 -0400 Received: from top.free-electrons.com ([176.31.233.9]:58521 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751487AbaEGMzj (ORCPT ); Wed, 7 May 2014 08:55:39 -0400 Date: Wed, 7 May 2014 14:55:36 +0200 From: Thomas Petazzoni To: Ezequiel Garcia Cc: Gregory CLEMENT , Mathias Nyman , Greg Kroah-Hartman , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Grant Likely , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v3 17/20] phy: Add support for USB cluster on the Armada 375 SoC Message-ID: <20140507145536.29003dfa@free-electrons.com> In-Reply-To: <20140506205330.GA27308@arch.cereza> References: <1399335255-589-1-git-send-email-gregory.clement@free-electrons.com> <1399335255-589-18-git-send-email-gregory.clement@free-electrons.com> <20140506205330.GA27308@arch.cereza> Organization: Free Electrons X-Mailer: Claws Mail 3.9.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Ezequiel Garcia, On Tue, 6 May 2014 17:53:30 -0300, Ezequiel Garcia wrote: > > +#define USB2_PHY_CONFIG_ENABLE BIT(0) /* active low */ > > + > > I still think it's more readable to use USB2_PHY_CONFIG_DISABLE. > It's just a nitpick, though. Yes, fixed. > > +static int armada375_usb_phy_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct phy *phy; > > + struct device_node *np = dev->of_node; > > + struct phy_provider *phy_provider; > > + void __iomem *usb_cluster_base; > > + struct device_node *xhci_node; > > + int i; > > + > > + usb_cluster_base = of_iomap(np, 0); > > + BUG_ON(!usb_cluster_base); > > + > > Isn't a bit extreme to call BUG_ON (and thus bring down the whole system) > in a phy driver? Indeed, fixed by a more normal error return. > > + for (i = 0; i < NB_PHY; i++) { > > + phy = devm_phy_create(dev, &armada375_usb_phy_ops, NULL); > > + if (IS_ERR(phy)) > > + dev_err(dev, "failed to create PHY n%d\n", i); > > + > > I think you're missing a continue/break here. Indeed, fixed, I just do a return from the ->probe() function if creating the PHY fails. > > +MODULE_DESCRIPTION("Armada 375 USB cluster driver"); > > +MODULE_AUTHOR("Gregory CLEMENT "); > > +MODULE_LICENSE("GPL"); > > GPL v2 ? Well, using just "GPL" seems to be the more common usage through the kernel: linux/drivers $ git grep MODULE_LICENSE | grep "\"GPL\"" | wc -l 4276 linux/drivers $ git grep MODULE_LICENSE | grep "\"GPLv2\"" | wc -l 5 linux/drivers $ git grep MODULE_LICENSE | grep "\"GPL v2\"" | wc -l 841 Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com