From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "David E. Box" <david.e.box@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
kristen.c.accardi@intel.com, jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers
Date: Wed, 7 May 2014 19:58:22 +0100 [thread overview]
Message-ID: <20140507195822.2d5dea58@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <536A69E8.6070707@zytor.com>
> I guess I don't see why the module isn't removable. Of course, any
> driver which calls iosf_mbi_available() will depend on it, preventing
> removal until *those* modules have been removed...
Going back over the current version you could unload it but you rely upon
the iosf_mbi_available caller locking the module in memory (which I think
is fair) and someone not forcing a hot unplug of any kind from userspace,
in which case life gets a bit odd as we clear mbi_pdev in the exit method
not when the device is unplugged. Probably for the best as with a remove
method you'd need to check the mbi_pdev pointer inside iosf_mbi_lock and
also clear it under the lock.
Alan
next prev parent reply other threads:[~2014-05-07 18:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 14:04 [PATCH 0/5] RAPL driver updates Jacob Pan
2014-04-28 14:04 ` [PATCH 1/5] powercap/rapl: further relax energy counter checks Jacob Pan
2014-04-28 14:04 ` [PATCH 2/5] powercap/rapl: add new cpu ids Jacob Pan
2014-04-28 14:04 ` [PATCH 3/5] x86, iosf: Add dummy functions for loadable modules Jacob Pan
2014-04-28 14:04 ` [PATCH 4/5] x86/iosf: kconfig and used by other drivers Jacob Pan
2014-04-28 14:04 ` [PATCH 5/5] powercap/rapl: change floor frequency for vallewview Jacob Pan
2014-04-29 2:45 ` R, Durgadoss
2014-04-29 13:02 ` Jacob Pan
2014-04-29 14:40 ` R, Durgadoss
2014-04-29 8:23 ` Jacob Pan
2014-04-29 22:33 ` [PATCH v2 0/4] RAPL driver updates David E. Box
2014-04-29 22:33 ` [PATCH v2 1/4] powercap/rapl: further relax energy counter checks David E. Box
2014-04-30 5:29 ` R, Durgadoss
2014-04-29 22:33 ` [PATCH v2 2/4] powercap/rapl: add new cpu ids David E. Box
2014-04-29 22:33 ` [PATCH v2 3/4] x86/iosf: Make IOSF driver modular and usable by more drivers David E. Box
2014-04-29 22:33 ` [PATCH v2 4/4] powercap/rapl: change floor frequency for vallewview David E. Box
2014-04-29 23:02 ` [PATCH v2 0/4] RAPL driver updates Rafael J. Wysocki
2014-04-29 23:38 ` Jacob Pan
2014-05-02 17:36 ` [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers David E. Box
2014-05-07 16:48 ` One Thousand Gnomes
2014-05-07 17:04 ` H. Peter Anvin
2014-05-07 17:10 ` One Thousand Gnomes
2014-05-07 17:14 ` H. Peter Anvin
2014-05-07 18:58 ` One Thousand Gnomes [this message]
2014-05-07 17:52 ` David E. Box
2014-05-09 20:44 ` [PATCH v4 0/4] x86/iosf: IOSF additional driver/device support David E. Box
2014-05-09 20:44 ` [PATCH v4 1/4] x86/iosf: Make IOSF driver modular and usable by more drivers David E. Box
2014-05-28 21:24 ` [tip:x86/platform] x86, iosf: " tip-bot for David E. Box
2014-05-09 20:44 ` [PATCH v4 2/4] arch: x86: added Quark MBI support David E. Box
2014-05-28 21:24 ` [tip:x86/platform] x86, iosf: Added Quark MBI identifiers tip-bot for Ong Boon Leong
2014-05-09 20:44 ` [PATCH v4 3/4] arch: x86: iosf_mbi: add Quark X1000 pci id David E. Box
2014-05-28 21:25 ` [tip:x86/platform] x86, iosf: Add Quark X1000 PCI ID tip-bot for Ong Boon Leong
2014-05-09 20:44 ` [PATCH v4 4/4] arch: x86: iosf_mbi: add pci id macros for better readability David E. Box
2014-05-28 21:25 ` [tip:x86/platform] x86, iosf: Add PCI ID " tip-bot for Ong Boon Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507195822.2d5dea58@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=david.e.box@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).