From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbaEGWHQ (ORCPT ); Wed, 7 May 2014 18:07:16 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:21429 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751111AbaEGWHN (ORCPT ); Wed, 7 May 2014 18:07:13 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/KFf47eFjsbERxFoxm5mr1 Date: Wed, 7 May 2014 15:07:07 -0700 From: Tony Lindgren To: Joel Fernandes Cc: Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List Subject: Re: [PATCH 02/26] ARM: OMAP: dmtimer: Add comments on OMAP1 clock framework Message-ID: <20140507220706.GD19102@atomide.com> References: <1398375849-6017-1-git-send-email-joelf@ti.com> <1398375849-6017-3-git-send-email-joelf@ti.com> <20140507152004.GC9502@atomide.com> <536AAA31.6080905@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <536AAA31.6080905@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Joel Fernandes [140507 14:49]: > On 05/07/2014 10:20 AM, Tony Lindgren wrote: > > * Joel Fernandes [140424 14:44]: > >> OMAP1 doesn't support clock framework, add a comment where needed > >> and correct a FIXME. > > > > This is at least a wrong comment, the original comment seems right > > to me. > > Can you elaborate a bit more please on the wrongness of the comment? > > I can change the comment to say "common clock" instead of "clock" if > that's the only problem here. The original comment is just fine, no need to patch it. We do have clock framework support for omap1, it was the first ever Linux clock framework that pretty much all other clock frameworks are based on. Just drop this patch it's misleading. Regards, Tony