From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbaEGWRs (ORCPT ); Wed, 7 May 2014 18:17:48 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41370 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbaEGWRr (ORCPT ); Wed, 7 May 2014 18:17:47 -0400 Date: Wed, 7 May 2014 15:17:42 -0700 From: josh@joshtriplett.org To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 39/45] rcutorture: Note diffs from git commits Message-ID: <20140507221742.GQ27924@cloud> References: <20140429002455.GA15461@linux.vnet.ibm.com> <1398731133-18925-1-git-send-email-paulmck@linux.vnet.ibm.com> <1398731133-18925-39-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398731133-18925-39-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 28, 2014 at 05:25:27PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The current scripting only keeps track of the git SHA-1 of the current > HEAD. This can cause confusion in cases where testing ran in a git > tree where changes had not yet been checked in. This commit therefore > also records the output of "git diff HEAD" to provide the information > needed to reconstruct the source tree that was tested. > > Signed-off-by: Paul E. McKenney Nit below. Reviewed-by: Josh Triplett > --- > tools/testing/selftests/rcutorture/bin/kvm.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/rcutorture/bin/kvm.sh b/tools/testing/selftests/rcutorture/bin/kvm.sh > index 4eed2a4f42c7..91661845fdec 100644 > --- a/tools/testing/selftests/rcutorture/bin/kvm.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm.sh > @@ -277,6 +277,11 @@ if test -d .git > then > git status >> $resdir/$ds/testid.txt > git rev-parse HEAD >> $resdir/$ds/testid.txt > + git diff HEAD > $T/git-diff 2>&1 > + if test -s $T/git-diff You don't need test here; you can use the return value of git diff. > + then > + cp $T/git-diff $resdir/$ds > + fi > fi > ___EOF___ > awk < $T/cfgcpu.pack \ > -- > 1.8.1.5 >