From: Robert Richter <rric@kernel.org>
To: suravee.suthikulpanit@amd.com
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Borislav Petkov <bp@suse.de>,
Daniel J Blueman <daniel@numascale.com>,
Andreas Herrmann <herrmann.der.user@googlemail.com>,
Myron Stowe <myron.stowe@redhat.com>
Subject: Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h
Date: Thu, 8 May 2014 11:01:48 +0200 [thread overview]
Message-ID: <20140508090148.GL32718@rric.localhost> (raw)
In-Reply-To: <20140508085905.GK32718@rric.localhost>
On 08.05.14 10:59:05, Robert Richter wrote:
> On 07.05.14 13:58:45, suravee.suthikulpanit@amd.com wrote:
> > @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void)
> > info = alloc_pci_root_info(min_bus, max_bus, node, link);
> > }
> >
> > + /*
> > + * The following code is only supported until Fam11h.
> > + * Newer processors will depend on ACPI MCFG table instead.
> > + */
> > + if (boot_cpu_data.x86 > 0x11)
> > + return 0;
> > +
> > /* get the default node and link for left over res */
>
> As this is the only substantial change of your patch, I would better
> drop ther rest or at least split it in two patches. Should this change
> also be for stable?
Of course adding the hostbridge must be also part of the patch, didn't
note this due to the other noise. See why the split would be good?
>
> -Robert
next prev parent reply other threads:[~2014-05-08 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 18:58 [PATCH V3 0/3] x86/pci Fix numa_node info for AMD hostbridge and misc clean up suravee.suthikulpanit
2014-05-07 18:58 ` [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h suravee.suthikulpanit
2014-05-08 8:59 ` Robert Richter
2014-05-08 9:01 ` Robert Richter [this message]
2014-05-08 14:39 ` Suravee Suthikulanit
2014-05-08 15:14 ` Robert Richter
2014-05-08 15:21 ` Suravee Suthikulanit
2014-05-08 15:37 ` Robert Richter
2014-05-08 16:22 ` Myron Stowe
2014-05-07 18:58 ` [PATCH V3 2/3] ACPI/PCI: Warn if we have to "guess" host bridge node information suravee.suthikulpanit
2014-05-07 18:58 ` [PATCH V3 3/3] PCI: Remove unnecessary 'quirk_amd_nb_node' suravee.suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508090148.GL32718@rric.localhost \
--to=rric@kernel.org \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=daniel@numascale.com \
--cc=herrmann.der.user@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=myron.stowe@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox