public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Cc: devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: lirc: Fix sparse warnings
Date: Thu, 8 May 2014 13:40:34 +0300	[thread overview]
Message-ID: <20140508104034.GE26890@mwanda> (raw)
In-Reply-To: <20140508103028.GD26890@mwanda>

On Thu, May 08, 2014 at 01:30:28PM +0300, Dan Carpenter wrote:
> On Thu, May 08, 2014 at 01:11:48PM +0300, Tuomas Tynkkynen wrote:
> > Fix sparse warnings by adding __user and __iomem annotations where
> > necessary and removing certain unnecessary casts.
> > 
> > Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> 
> This patch adds spaces between the cast and the variable.  There
> shouldn't be a cast.
                 ^^^^
I meant space.  There shouldn't be a space.

regards,
dan carpenter


      reply	other threads:[~2014-05-08 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 10:11 [PATCH] staging: lirc: Fix sparse warnings Tuomas Tynkkynen
2014-05-08 10:30 ` Dan Carpenter
2014-05-08 10:40   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140508104034.GE26890@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=tuomas.tynkkynen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox