Re: [PATCH 2/2] treewide: remove all open implementation of nice_to_rlimit()/rlimit_to_nice().

[Peter Zijlstra <peterz@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Thu, May 08, 2014 at 06:33:49PM +0900, Dongsheng Yang wrote:
> As there are already two inline functions in prio.h to handle the convertiion
> between nice value and rlimit style value of priority, this patch remove all
> open implementation of these two functions.
> 
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
>  drivers/staging/android/binder.c | 2 +-
>  kernel/sched/core.c              | 2 +-
>  kernel/sys.c                     | 6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index 179b21b..9311bb6 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -436,7 +436,7 @@ static void binder_set_nice(long nice)
>  		set_user_nice(current, nice);
>  		return;
>  	}
> -	min_nice = 20 - current->signal->rlim[RLIMIT_NICE].rlim_cur;
> +	min_nice = rlimit_to_nice(current->signal->rlim[RLIMIT_NICE].rlim_cur);
>  	binder_debug(BINDER_DEBUG_PRIORITY_CAP,
>  		     "%d: nice value %ld not allowed use %ld instead\n",
>  		      current->pid, nice, min_nice);

One does wonder WTF binder is smoking.. must be strong stuff. That's
some qualitee crackpot code there.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]