RE: [PATCH] usb: gadget: fsl: check vbus presence on probe

suresh.gupta
2014-05-01T14:42:55Z

Give me some time (actually some days), I will try this and update you.

> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Thursday, May 01, 2014 1:42 AM
> To: Paul Fertser
> Cc: Felipe Balbi; Li Yang-Leo-R58472; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; Gupta Suresh-B42813
> Subject: Re: [PATCH] usb: gadget: fsl: check vbus presence on probe
>
> +Suresh
>
> (top-posting, yeah yeah :-)
>
> On Wed, Apr 30, 2014 at 11:27:45PM +0400, Paul Fertser wrote:
> > Hello,
> >
> > Thank you for the review.
> >
> > On Wed, Apr 30, 2014 at 11:06:25AM -0500, Felipe Balbi wrote:
> > > On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote:
> > > > If VBUS is already present during the driver initialisation, the
> > >
> > > s/initialisation/initialization
> >
> > If I'm understanding [1] properly, both spelling variants are correct.
> >
> > > > + /* Now let it settle a bit and sense VBUS */
> > > > + msleep_interruptible(1);
> > > > + if (fsl_readl(&dr_regs->otgsc) & OTGSC_STS_B_SESSION_VALID)
> > > > + udc_controller->vbus_active = 1;
> > >
> > > good fix, should this go to stable ?
> >
> > I was reluctant to Cc stable because I'm not sure which versions need
> > to be fixed, as I've seen an earlier version (3.0 something or a bit
> > before that probably) working without this (no idea why); also I'm not
> > sure about that msleep as it's deduced solely from experimenting with
> > a particular i.MX model, I hoped someone from Freescale would comment
> > on it. I've seen your review [2] on a related patch and my fix should
> > have been obvious to Suresh (and trivial to test on different boards),
> > yet he didn't implement it, that worries me a bit.
> >
> > [1]
> > https://en.wikipedia.org/wiki/American_and_British_English_spelling_di
> > fferences#-ise.2C_-ize_.28-isation.2C_-ization.29
> > [2] https://patchwork.kernel.org/patch/3822321/
> > --
> > Be free, use free (http://www.gnu.org/philosophy/free-sw.html)
> software!
> > mailto:fercerpav@gmail.com
>
> --
> balbi