[patch] Documentation/email-clients.txt: add a section about git

[patch] Documentation/email-clients.txt: add a section about git

[Dan Carpenter]

These days most people don't use git to send patches so I have added a
section about that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
index 4e30eba..9004a5fd 100644
--- a/Documentation/email-clients.txt
+++ b/Documentation/email-clients.txt
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ======================================================================
 
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then
+send the patch to list.
+
 General Preferences
 ----------------------------------------------------------------------
 Patches for the Linux kernel are submitted via email, preferably as

Re: [patch] Documentation/email-clients.txt: add a section about git

[Laura Abbott]

On 5/7/2014 4:17 AM, Dan Carpenter wrote:
> These days most people don't use git to send patches so I have added a
> section about that.
> 

Do you mean most people *do* use git to send patches? Or most people don't
use e-mail clients?

Laura

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

Re: [patch] Documentation/email-clients.txt: add a section about git

[Dan Carpenter]

On Wed, May 07, 2014 at 09:06:54AM -0700, Laura Abbott wrote:
> On 5/7/2014 4:17 AM, Dan Carpenter wrote:
> > These days most people don't use git to send patches so I have added a
> > section about that.
> > 
> 
> Do you mean most people *do* use git to send patches? Or most people don't
> use e-mail clients?

Gar...  Of course.  I'll resend.

regards,
dan carpenter

[patch v2] Documentation/email-clients.txt: add a section about git

[Dan Carpenter]

These days most people use git to send patches so I have added a section
about that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Fixed changelog

diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
index 4e30eba..9004a5fd 100644
--- a/Documentation/email-clients.txt
+++ b/Documentation/email-clients.txt
@@ -1,6 +1,17 @@
 Email clients info for Linux
 ======================================================================
 
+Git
+----------------------------------------------------------------------
+These days most developers use `git send-email` instead of regular
+email clients.  On the receiving end, maintainers use `git am` to
+apply the patches.
+
+If you are new to git then send your first patch to yourself.  Save it
+as raw text including all the headers.  Run `cat raw_email.txt | git am`
+and then review the changelog with `git log -p`.  When that works then
+send the patch to list.
+
 General Preferences
 ----------------------------------------------------------------------
 Patches for the Linux kernel are submitted via email, preferably as
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch v2] Documentation/email-clients.txt: add a section about git

[Julian Andres Klode]

On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote:
> +as raw text including all the headers.  Run `cat raw_email.txt | git am`

`cat raw_email.txt | git am` seems a bit pointless. Why not simply
`git am raw_email.txt`? `git am < raw_email.txt` does the same too
and avoids the useless cat as well. 

No point in running two processes when the same can be done in a
simpler way in one process, IMO.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Please do not top-post if possible.

Re: [patch v2] Documentation/email-clients.txt: add a section about git

[Hillf Danton]

On Thu, May 8, 2014 at 5:05 PM, Julian Andres Klode <jak@jak-linux.org> wrote:
> On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote:
>> +as raw text including all the headers.  Run `cat raw_email.txt | git am`
>
> `cat raw_email.txt | git am` seems a bit pointless. Why not simply
> `git am raw_email.txt`? `git am < raw_email.txt` does the same too
> and avoids the useless cat as well.
>
> No point in running two processes when the same can be done in a
> simpler way in one process, IMO.
>
And this helps most developers little, but is more valuable for those who
dont use 'git send-mail' everyday if the detail of cmdline is provided, say
send a patch file with 'git send-mail' through gmail.

We will say double thanks to you, Dan, if you really help us tame gmail.

And a howto to tame gmail is doule apprecaited.

thanks
Hillf

Re: [patch v2] Documentation/email-clients.txt: add a section about git

[Namhyung Kim]

Hi Dan,

On Thu, 8 May 2014 11:44:12 +0300, Dan Carpenter wrote:
> These days most people use git to send patches so I have added a section
> about that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Fixed changelog
>
> diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
> index 4e30eba..9004a5fd 100644
> --- a/Documentation/email-clients.txt
> +++ b/Documentation/email-clients.txt
> @@ -1,6 +1,17 @@
>  Email clients info for Linux
>  ======================================================================
>  
> +Git
> +----------------------------------------------------------------------
> +These days most developers use `git send-email` instead of regular
> +email clients.  On the receiving end, maintainers use `git am` to
> +apply the patches.
> +
> +If you are new to git then send your first patch to yourself.  Save it
> +as raw text including all the headers.  Run `cat raw_email.txt | git am`
> +and then review the changelog with `git log -p`.  When that works then

Also the -p option is not needed for just checking the changelog IMHO.
If one needs to check the patch itself too, I think `git show` is
slightly better since it only shows the single commit applied.

Thanks,
Namhyung

Re: [patch v2] Documentation/email-clients.txt: add a section about git

[Dan Carpenter]

On Fri, May 09, 2014 at 09:24:56AM +0900, Namhyung Kim wrote:
> > +Git
> > +----------------------------------------------------------------------
> > +These days most developers use `git send-email` instead of regular
> > +email clients.  On the receiving end, maintainers use `git am` to
> > +apply the patches.
> > +
> > +If you are new to git then send your first patch to yourself.  Save it
> > +as raw text including all the headers.  Run `cat raw_email.txt | git am`
> > +and then review the changelog with `git log -p`.  When that works then
> 
> Also the -p option is not needed for just checking the changelog IMHO.
> If one needs to check the patch itself too, I think `git show` is
> slightly better since it only shows the single commit applied.
> 

I know you can leave the -p off but I wanted it on and I wanted the log
so they could see their patch and how the format compared to other
commits.

You guys are over thinking this.  It's not commands for all ages.  If
you type `cat patch.txt | git am` or if you type `git am < patch.txt`,
those are things I don't care about.

regards,
dan carpenter

Re: [patch v2] Documentation/email-clients.txt: add a section about git

[Dan Carpenter]

On Thu, May 08, 2014 at 05:28:46PM +0800, Hillf Danton wrote:
> And a howto to tame gmail is doule apprecaited.

There is actually a gmail section in the man page.  `man git send-email`
It's a the bottom.


EXAMPLE
   Use gmail as the smtp server
       To use git send-email to send your patches through the GMail SMTP
       server, edit ~/.gitconfig to specify your account settings:

           [sendemail]
                   smtpencryption = tls
                   smtpserver = smtp.gmail.com
                   smtpuser = yourname@gmail.com
                   smtpserverport = 587

       Once your commits are ready to be sent to the mailing list, run the
       following commands:

           $ git format-patch --cover-letter -M origin/master -o outgoing/
           $ edit outgoing/0000-*
           $ git send-email outgoing/*

       Note: the following perl modules are required Net::SMTP::SSL,
       MIME::Base64 and Authen::SASL


regards,
dan carpenter

Re: [patch v2] Documentation/email-clients.txt: add a section about git

[Randy Dunlap]

On 05/08/2014 01:44 AM, Dan Carpenter wrote:
> These days most people use git to send patches so I have added a section
> about that.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Fixed changelog
> 
> diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
> index 4e30eba..9004a5fd 100644
> --- a/Documentation/email-clients.txt
> +++ b/Documentation/email-clients.txt
> @@ -1,6 +1,17 @@
>  Email clients info for Linux
>  ======================================================================
>  
> +Git
> +----------------------------------------------------------------------
> +These days most developers use `git send-email` instead of regular
> +email clients.  On the receiving end, maintainers use `git am` to
> +apply the patches.
> +

Why is there nothing here about how to use 'git send-email' to send patches?


> +If you are new to git then send your first patch to yourself.  Save it
> +as raw text including all the headers.  Run `cat raw_email.txt | git am`
> +and then review the changelog with `git log -p`.  When that works then
> +send the patch to list.
> +
>  General Preferences
>  ----------------------------------------------------------------------
>  Patches for the Linux kernel are submitted via email, preferably as


-- 
~Randy