From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, himangi774@gmail.com,
sachin.kamat@linaro.org, fempsci@gmail.com,
nandu.hgowda@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c
Date: Fri, 9 May 2014 13:42:02 +0300 [thread overview]
Message-ID: <20140509104202.GG4963@mwanda> (raw)
In-Reply-To: <20140509100220.GA6446@devel.8.8.4.4>
On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
> clean up checkpatch.pl warning:
> WARNING: please no spaces at the start of a line in
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> -#ifdef RLD_TRANS_DEBUGx
> - if (1 || cxt1e1_log_level >= LOG_MONITOR2)
> +#ifdef RLD_TRANS_DEBUG
> + if (1 || cxt1e1_log_level >= LOG_MONITOR2)
> #else
You fixed a typo here. I don't care about it, because we are going to
delete this code anyway. But normally I would ask you to redo the patch
because it should be done separately, and it should be described in the
changelog instead of slipped in secretly.
But in this case, I don't care so you got lucky.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-09 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 10:02 [PATCH 1/5] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c Daeseok Youn
2014-05-09 10:42 ` Dan Carpenter [this message]
2014-05-09 13:56 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509104202.GG4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fempsci@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nandu.hgowda@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox