From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757208AbaEJANx (ORCPT ); Fri, 9 May 2014 20:13:53 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:44457 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754899AbaEJANw (ORCPT ); Fri, 9 May 2014 20:13:52 -0400 Date: Fri, 9 May 2014 17:13:46 -0700 From: "Paul E. McKenney" To: josh@joshtriplett.org Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 20/45] torture: Include "Stopping" string to torture_kthread_stopping() Message-ID: <20140510001346.GC8754@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20140429002455.GA15461@linux.vnet.ibm.com> <1398731133-18925-1-git-send-email-paulmck@linux.vnet.ibm.com> <1398731133-18925-20-git-send-email-paulmck@linux.vnet.ibm.com> <20140507213736.GL27924@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140507213736.GL27924@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14051000-3532-0000-0000-000001A56C0C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 07, 2014 at 02:37:36PM -0700, josh@joshtriplett.org wrote: > On Mon, Apr 28, 2014 at 05:25:08PM -0700, Paul E. McKenney wrote: > > From: "Paul E. McKenney" > > > > Currently, torture_kthread_stopping() prints only the name of the > > kthread that is stopping, which can be unedifying. This commit therefore > > adds "Stopping" to make things more evident. > > > > Signed-off-by: Paul E. McKenney > > Feedback below. > > > kernel/torture.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/torture.c b/kernel/torture.c > > index acc9afc2f26e..f329848c3eee 100644 > > --- a/kernel/torture.c > > +++ b/kernel/torture.c > > @@ -674,8 +674,11 @@ EXPORT_SYMBOL_GPL(torture_must_stop_irq); > > */ > > void torture_kthread_stopping(char *title) > > { > > + char buf[128]; > > + > > + snprintf(buf, sizeof(buf), "Stopping %s", title); > > if (verbose) > > - VERBOSE_TOROUT_STRING(title); > > + VERBOSE_TOROUT_STRING(buf); > > This seems like a case where the macro has led to poorer code; rather > than using sprintf into a temporary buffer, this should just print. > Please consider fixing the output macros to allow formats, as the pr_* > macros do. > > Also, why do you need "if (verbose)" if the name of the macro has > VERBOSE_ in it; shouldn't that mean it checks verbosity itself? > (Another good reason not to create a unique verbosity level mechanism, > and to use the kernel mechanisms instead.) Good catch, removed the redundant "if (verbose)". My attempts in the past to leverage existing in-kernel verbosity controls has caused problems such as the output appearing or not depending on the distro in question. Thanx, Paul > > while (!kthread_should_stop()) { > > torture_shutdown_absorb(title); > > schedule_timeout_uninterruptible(1); > > -- > > 1.8.1.5 > > >