From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbaELJJA (ORCPT ); Mon, 12 May 2014 05:09:00 -0400 Received: from top.free-electrons.com ([176.31.233.9]:56854 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751058AbaELJI7 (ORCPT ); Mon, 12 May 2014 05:08:59 -0400 Date: Mon, 12 May 2014 11:08:56 +0200 From: Alexandre Belloni To: Nicolas Ferre Cc: Boris BREZILLON , linux-arm-kernel@lists.infradead.org, Jean-Christophe PLAGNIOL-VILLARD , linux-kernel@vger.kernel.org, Bo Shen Subject: Re: [PATCH 1/2] ARM: at91: add PWM pinctrl to SAMA5D3 Message-ID: <20140512090855.GA29318@piout.net> References: <20140510091017.GA22329@piout.net> <53708EFF.1030604@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53708EFF.1030604@atmel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2014 at 11:06:07 +0200, Nicolas Ferre wrote : > On 10/05/2014 11:10, Alexandre Belloni : > > Hi Nicolas, > > > > On 09/05/2014 at 15:44:27 +0200, Nicolas Ferre wrote : > >> Signed-off-by: Nicolas Ferre > >> --- > >> arch/arm/boot/dts/sama5d3.dtsi | 82 ++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 82 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi > >> index 9caa06b3641e..ed7943745f23 100644 > >> --- a/arch/arm/boot/dts/sama5d3.dtsi > >> +++ b/arch/arm/boot/dts/sama5d3.dtsi > >> @@ -583,6 +583,88 @@ > >> }; > >> }; > >> > >> + pwm0 { > >> + pinctrl_pwm0_pwmh0_0: pwm0_pwmh0-0 { > >> + atmel,pins = > >> + ; /* PA20 periph B, conflicts with ISI_D4 and LCDDAT20 */ > > > > Didn't we decide at some point to stop adding comments for the pinctrl ? > > At least, I would say that "PA20 periph B" doesn't add any useful > > information. > > Yes, we said that for the description and you are right saying that > saying again the pin configuration doesn't make sense. On the other > hand, I tend to like the "conflicts with ..." part of it (and it is > automatically generated). > > So, should we keep this part? > Yes, it adds real information. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com