From: Frederic Weisbecker <fweisbec@gmail.com>
To: Kirill Tkhai <tkhai@yandex.ru>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org
Subject: Re: [PATCH] sched,nohz: Change rq->nr_running always using wrappers
Date: Mon, 12 May 2014 19:56:12 +0200 [thread overview]
Message-ID: <20140512175609.GC6127@localhost.localdomain> (raw)
In-Reply-To: <20140508225830.2469.97461.stgit@localhost>
On Fri, May 09, 2014 at 03:00:14AM +0400, Kirill Tkhai wrote:
> Sometimes nr_running may cross 2 but interrupt is not being
> sent to rq's cpu. In this case we don't reenable timer.
> Looks like, this may be a reason of rare unexpected effects,
> if nohz is enabled.
>
> Patch replaces all places of direct changing of nr_running
> and makes add_nr_running() caring about crossing border.
>
> Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@kernel.org>
Right I had that issue with throttling in my TODO list.
Thanks for fixing that:
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
next prev parent reply other threads:[~2014-05-12 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 23:00 [PATCH] sched,nohz: Change rq->nr_running always using wrappers Kirill Tkhai
2014-05-09 9:12 ` Peter Zijlstra
2014-05-12 17:56 ` Frederic Weisbecker [this message]
2014-05-19 13:09 ` [tip:sched/core] sched,nohz: Change rq-> nr_running " tip-bot for Kirill Tkhai
2014-05-22 12:28 ` [tip:sched/core] sched, nohz: Change rq-> nr_running to always use wrappers tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512175609.GC6127@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox