Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

[Guenter Roeck <linux@roeck-us.net>]

On Mon, May 12, 2014 at 06:48:06PM +0200, Jean Delvare wrote:
> Hi Guenter,
> 
> On Mon, 12 May 2014 08:59:31 -0700, Guenter Roeck wrote:
> > I only see the adt7462 driver scanning for 0x5c. Guess I'll accept the
> > address for now; I don't see a good reason not to.
> 
> sensors-detect also scans it for the SMSC EMC1072, EMC1073 and EMC1074
> which we don't support yet. I have no objection to scanning it.
> 
> > Couple of other questions:
> > - would it make sense to relax store_hyst to not return ERANGE but use clamp_val
> >   instead ?
> 
> Yes, I had exactly the same thought when reading the code this morning.
> 
> > - Currently hyst can be stored for all crit attributes even though there is only
> >   one hyst register. Should we change this to only support writing it for
> >   temp1_crit_hyst ?
> 
> Yes, that would align this driver with what other drivers do.
> 
> > - I might convert the driver to use regmap if I find the time. Do you have any
> >   concerns with that ?
> 
> I know nothing about regmap, so no objection, I simply don't care ;-)
> 
Pretty much provides caching.

I'll submit patches for all of it, plus some more (add support for fault
attributes and for the alarm attributes on the emc14x2 chips, and add driver
documentation).