From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbaEMRo1 (ORCPT ); Tue, 13 May 2014 13:44:27 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:42434 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbaEMRoU (ORCPT ); Tue, 13 May 2014 13:44:20 -0400 Date: Tue, 13 May 2014 10:44:13 -0700 From: "Paul E. McKenney" To: josh@joshtriplett.org Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 41/45] torture: Put qemu into the background Message-ID: <20140513174413.GK18164@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20140429002455.GA15461@linux.vnet.ibm.com> <1398731133-18925-1-git-send-email-paulmck@linux.vnet.ibm.com> <1398731133-18925-41-git-send-email-paulmck@linux.vnet.ibm.com> <20140507221858.GR27924@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140507221858.GR27924@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14051317-0928-0000-0000-000001DB7890 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 07, 2014 at 03:18:58PM -0700, josh@joshtriplett.org wrote: > On Mon, Apr 28, 2014 at 05:25:29PM -0700, Paul E. McKenney wrote: > > From: "Paul E. McKenney" > > > > Currently, qemu runs in the foreground, which prevents the script from > > killing it in case the kernel locks up. This commit therefore places > > qemu into the background, allowing the script to recover from lockups. > > > > Signed-off-by: Paul E. McKenney > > qemu originally did run in the background before this patch series; > please merge this into the patch that introduces the echo and thus > breaks that. Turned out that the conflicts weren't as bad as I had feared, so done! Thanx, Paul > > tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > > index b1e85b049075..67e89f06e77f 100755 > > --- a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > > +++ b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > > @@ -157,7 +157,7 @@ then > > echo Build-only run specified, boot/test omitted. > > exit 0 > > fi > > -$QEMU $qemu_args -m 512 -kernel $builddir/$BOOT_IMAGE -append "$qemu_append $boot_args"; echo $? > $resdir/qemu-retval & > > +( $QEMU $qemu_args -m 512 -kernel $builddir/$BOOT_IMAGE -append "$qemu_append $boot_args"; echo $? > $resdir/qemu-retval ) & > > qemu_pid=$! > > commandcompleted=0 > > echo Monitoring qemu job at pid $qemu_pid > > -- > > 1.8.1.5 > > >