From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754663AbaEMTCO (ORCPT ); Tue, 13 May 2014 15:02:14 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:49324 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbaEMTCK (ORCPT ); Tue, 13 May 2014 15:02:10 -0400 Date: Tue, 13 May 2014 12:01:51 -0700 From: "Paul E. McKenney" To: josh@joshtriplett.org Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 10/45] torture: Rename RCU_BUILDONLY to TORTURE_BUILDONLY Message-ID: <20140513190151.GO18164@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20140429002455.GA15461@linux.vnet.ibm.com> <1398731133-18925-1-git-send-email-paulmck@linux.vnet.ibm.com> <1398731133-18925-10-git-send-email-paulmck@linux.vnet.ibm.com> <20140507212403.GE27924@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140507212403.GE27924@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14051319-3532-0000-0000-000001B89AAF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 07, 2014 at 02:24:03PM -0700, josh@joshtriplett.org wrote: > On Mon, Apr 28, 2014 at 05:24:58PM -0700, Paul E. McKenney wrote: > > From: "Paul E. McKenney" > > > > This commit makes the torture scripts a bit more RCU-independent. > > And removes unnecessary exports; please document that. With that > change: Good eyes, fixes! Thanx, Paul > > Signed-off-by: Paul E. McKenney > Reviewed-by: Josh Triplett > > > --- > > tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +- > > tools/testing/selftests/rcutorture/bin/kvm.sh | 9 ++++++--- > > 2 files changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > > index e82f4f201c8c..86e6ffe6df45 100755 > > --- a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > > +++ b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > > @@ -152,7 +152,7 @@ boot_args="`configfrag_boot_params "$boot_args" "$config_template"`" > > boot_args="`per_version_boot_params "$boot_args" $builddir/.config $seconds`" > > > > echo $QEMU $qemu_args -m 512 -kernel $builddir/arch/x86/boot/bzImage -append \"$qemu_append $boot_args\" > $resdir/qemu-cmd > > -if test -n "$RCU_BUILDONLY" > > +if test -n "$TORTURE_BUILDONLY" > > then > > echo Build-only run specified, boot/test omitted. > > exit 0 > > diff --git a/tools/testing/selftests/rcutorture/bin/kvm.sh b/tools/testing/selftests/rcutorture/bin/kvm.sh > > index 08c90cba79d2..73c586f6bdf6 100644 > > --- a/tools/testing/selftests/rcutorture/bin/kvm.sh > > +++ b/tools/testing/selftests/rcutorture/bin/kvm.sh > > @@ -81,7 +81,7 @@ do > > shift > > ;; > > --buildonly) > > - RCU_BUILDONLY=1; export RCU_BUILDONLY > > + TORTURE_BUILDONLY=1 > > ;; > > --configs) > > checkarg --configs "(list of config files)" "$#" "$2" '^[^/]*$' '^--' > > @@ -374,7 +374,7 @@ then > > echo KVM="$KVM; export KVM" > > echo KVPATH="$KVPATH; export KVPATH" > > echo PATH="$PATH; export PATH" > > - echo RCU_BUILDONLY="$RCU_BUILDONLY; export RCU_BUILDONLY" > > + echo TORTURE_BUILDONLY="$TORTURE_BUILDONLY; export TORTURE_BUILDONLY" > > echo TORTURE_INITRD="$TORTURE_INITRD; export TORTURE_INITRD" > > echo TORTURE_KMAKE_ARG="$TORTURE_KMAKE_ARG; export TORTURE_KMAKE_ARG" > > echo RCU_QEMU_CMD="$RCU_QEMU_CMD; export RCU_QEMU_CMD" > > @@ -402,4 +402,7 @@ echo > > echo > > echo " --- `date` Test summary:" > > echo Results directory: $resdir/$ds > > -kvm-recheck.sh $resdir/$ds > > +if test -n "$TORTURE_BUILDONLY" > > +then > > + kvm-recheck.sh $resdir/$ds > > +fi > > -- > > 1.8.1.5 > > >