* [PATCH] staging: fixed warning shown by checkpatch tool on cb_das16_cs.c file
@ 2014-05-10 15:46 Raghavendra Ganiga
2014-05-14 11:18 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Raghavendra Ganiga @ 2014-05-10 15:46 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, devel; +Cc: ravi23ganiga, linux-kernel
This is a patch to fix
the warnings shown
by checkpatch tool on file
cb_das16_cs.c file
Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/cb_das16_cs.c b/drivers/staging/comedi/drivers/cb_das16_cs.c
index 645fcb0..eb1b92d 100644
--- a/drivers/staging/comedi/drivers/cb_das16_cs.c
+++ b/drivers/staging/comedi/drivers/cb_das16_cs.c
@@ -184,6 +184,7 @@ static int das16cs_ao_winsn(struct comedi_device *dev,
for (bit = 15; bit >= 0; bit--) {
int b = (d >> bit) & 0x1;
+
b <<= 1;
outw(status1 | b | 0x0000, dev->iobase + DAS16CS_MISC1);
udelay(1);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fixed warning shown by checkpatch tool on cb_das16_cs.c file
2014-05-10 15:46 [PATCH] staging: fixed warning shown by checkpatch tool on cb_das16_cs.c file Raghavendra Ganiga
@ 2014-05-14 11:18 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-05-14 11:18 UTC (permalink / raw)
To: Raghavendra Ganiga; +Cc: abbotti, hsweeten, gregkh, devel, linux-kernel
On Sat, May 10, 2014 at 09:16:29PM +0530, Raghavendra Ganiga wrote:
> This is a patch to fix
> the warnings shown
> by checkpatch tool on file
> cb_das16_cs.c file
Emails should be line wrapped at 72 characters. 30 is too small.
Subject prefix should be: [patch] Staging: comedi: ...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-14 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-10 15:46 [PATCH] staging: fixed warning shown by checkpatch tool on cb_das16_cs.c file Raghavendra Ganiga
2014-05-14 11:18 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox