Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()

Greg KH
2014-05-15T21:54:22Z

On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
> Fix some coding style issues concerning printk() usage.
>
> Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> index 61a3092..3577d20 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -384,8 +384,9 @@ static int p80211knetdev_hard_start_xmit(struct sk_buff *skb,
> */
> if (skb->protocol != ETH_P_80211_RAW) {
> netif_start_queue(wlandev->netdev);
> - printk(KERN_NOTICE
> - "Tx attempt prior to association, frame dropped.\n");
> + pr_notice(
> + "Tx attempt prior to association, frame dropped\n"
> + );

Can't these be netdev messages, or at the least, dev_* messages?

thanks,

greg k-h