From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755710AbaENMzs (ORCPT ); Wed, 14 May 2014 08:55:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25504 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755097AbaENMzq (ORCPT ); Wed, 14 May 2014 08:55:46 -0400 Date: Wed, 14 May 2014 15:55:24 +0300 From: Dan Carpenter To: Felipe Balbi Cc: Greg Kroah-Hartman , Grant Likely , Rob Herring , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] usb: phy: msm: devm_ioremap() doesn't return ERR_PTRs Message-ID: <20140514125524.GB14571@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400050877.8431.9.camel@iivanov-dev> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be updated. Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index c522c4f..bd32257 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c @@ -1587,8 +1587,8 @@ static int msm_otg_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); - if (IS_ERR(motg->regs)) - return PTR_ERR(motg->regs); + if (!motg->regs) + return -ENOMEM; /* * NOTE: The PHYs can be multiplexed between the chipidea controller