public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-kernel@vger.kernel.org,
	"'Florian Fainelli'" <f.fainelli@gmail.com>,
	"'Thierry Reding'" <thierry.reding@gmail.com>,
	"'Joe Perches'" <joe@perches.com>,
	"'Dan Carpenter'" <dan.carpenter@oracle.com>
Subject: Re: [PATCH] lib: devres: Mark devm_request_and_ioremap() as deprecated
Date: Wed, 14 May 2014 16:30:43 +0200	[thread overview]
Message-ID: <20140514143043.GC17301@kroah.com> (raw)
In-Reply-To: <002301cf6f36$b1d11320$15733960$%han@samsung.com>

On Wed, May 14, 2014 at 02:38:11PM +0900, Jingoo Han wrote:
> devm_request_and_ioremap() was obsoleted by devm_ioremap_resource().
> (7509657 "lib: devres: Introduce devm_ioremap_resource()") So,
> let's mark it as deprecated in order to stop using it.
> 
> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> ---
>  include/linux/device.h |    4 ++--
>  lib/devres.c           |    1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 67f003a..769c86b 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -627,8 +627,8 @@ extern void *devm_kmemdup(struct device *dev, const void *src, size_t len,
>  			  gfp_t gfp);
>  
>  void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res);
> -void __iomem *devm_request_and_ioremap(struct device *dev,
> -			struct resource *res);
> +void __deprecated __iomem *devm_request_and_ioremap(struct device *dev,
> +						    struct resource *res);

If no one uses it, just delete it entirely from the tree, no need to
mark __deprecated, that's not going to stop new people from using it.

Also, I see a number of existing users in Linus's tree, please remove
those usages as well.

greg k-h

      reply	other threads:[~2014-05-14 14:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  5:38 [PATCH] lib: devres: Mark devm_request_and_ioremap() as deprecated Jingoo Han
2014-05-14 14:30 ` 'Greg Kroah-Hartman' [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140514143043.GC17301@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=f.fainelli@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox