From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pawel Lebioda <pawel.lebioda89@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: usbip: Fix bad fuction definitions in usbip
Date: Wed, 14 May 2014 22:35:30 +0300 [thread overview]
Message-ID: <20140514193530.GC8897@mwanda> (raw)
In-Reply-To: <20140514192823.GA5491@ThinkPad>
On Wed, May 14, 2014 at 09:28:27PM +0200, Pawel Lebioda wrote:
> Fix bad function definitions in all files from drivers/staging/usbip directory
>
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
This is fine, but next time try to be more specific in the subject and
also in the changelog. Put the sparse warning in the changelog. Say
that you are adding "void".
Btw, the reason for the void is because if it's not void then the
compiler won't complain if you pass a parameter to it.
void frob()
{
printf("foo\n");
}
int main(void)
{
frob(1, 2, 3);
return 0;
}
regards,
dan carpenter
prev parent reply other threads:[~2014-05-14 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 19:28 [PATCH] staging: usbip: Fix bad fuction definitions in usbip Pawel Lebioda
2014-05-14 19:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514193530.GC8897@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.lebioda89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox