Re: mm: NULL ptr deref handling mmaping of special mappings

Andy Lutomirski
2014-05-15T21:43:11Z

On Thu, May 15, 2014 at 2:31 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> On Fri, May 16, 2014 at 12:19:14AM +0400, Cyrill Gorcunov wrote:
>>
>> I see what you mean. We're rather targeting on bare x86-64 at the moment
>> but compat mode is needed as well (not yet implemented though). I'll take
>> a precise look into this area. Thanks!
>
> Indeed, because we were not running 32bit tasks vdso32-setup.c::arch_setup_additional_pages
> has never been called. That's the mode we will have to implement one day.
>
> Looking forward the question appear -- will VDSO_PREV_PAGES and rest of variables
> be kind of immutable constants? If yes, we could calculate where the additional
> vma lives without requiring any kind of [vdso] mark in proc/pid/maps output.

Please don't!

These might, in principle, even vary between tasks on the same system.
Certainly the relative positions of the vmas will be different
between 3.15 and 3.16, since we need almost my entire cleanup series
to reliably put them into their 3.16 location. And I intend to change
the number of pages in 3.16 or 3.17.

--Andy