Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems

Dave Chinner
2014-05-15T03:05:13Z

On Wed, May 14, 2014 at 10:17:49PM -0400, Theodore Ts'o wrote:
> On Thu, May 15, 2014 at 07:54:57AM +1000, Dave Chinner wrote:
> > On Tue, May 13, 2014 at 08:31:02PM +0200, Mateusz Guzik wrote:
> > > This helps hang troubleshooting efforts when only dmesg is available.
> >
> > I really don't think that spamming dmesg every time a filesystem is
> > frozen or thawed is a good idea. This happens a *lot* when systems
> > are using snapshots, and for the most part nobody cares about
> > freeze/thaw cycles because they almost always work just fine.
>
> The problems people are worried about are when there is freezing and
> unfreezing taking place in combination with a machine-level
> suspend/resume cycle, no? What if we only spammed dmesg when doing a
> suspend/resume?

Filesystems are not frozen by power management based suspend/resume
cycles. That uses sync and then assumes that it can't race with
with the filesystem doing metadata writeback while the suspend code
is creating the freeze image. Hence there won't by any syslog
spam because freeze is not used. ;)

Sure, I've been advocating that suspend should use freezing rather
than sync for years, but that's never happened...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com