From: Peter Zijlstra <peterz@infradead.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Juri Lelli <juri.lelli@gmail.com>,
Bruce Allan <bruce.w.allan@intel.com>
Subject: Re: [REGRESSION] funny sched_domain build failure during resume
Date: Thu, 15 May 2014 17:12:56 +0200 [thread overview]
Message-ID: <20140515151256.GR30445@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140515144113.GA2886@cmpxchg.org>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Thu, May 15, 2014 at 10:41:14AM -0400, Johannes Weiner wrote:
> Is it necessary that resume paths allocate at all? Freeing at suspend
> what you have to reallocate at resume is asking for trouble. It's not
> just higher order allocations, either, even order-0 allocations are
> less reliable without GFP_IOFS. So I think this should be avoided as
> much as possible.
Well, in my case its because suspend does an effective hot-unplug of all
CPUs in the system except CPU0.
And if the cpu topology changes I need to allocate new data structures
and free the old ones.
The reverse is true on resume, it hot-plugs all CPUs again, same story.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-15 15:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 16:04 [REGRESSION] funny sched_domain build failure during resume Tejun Heo
2014-05-09 16:15 ` Peter Zijlstra
2014-05-14 14:00 ` Peter Zijlstra
2014-05-14 14:05 ` Peter Zijlstra
2014-05-14 17:02 ` Tejun Heo
2014-05-14 17:10 ` Peter Zijlstra
2014-05-14 22:36 ` Tejun Heo
2014-05-15 8:57 ` Peter Zijlstra
2014-05-15 14:41 ` Johannes Weiner
2014-05-15 15:12 ` Peter Zijlstra [this message]
2014-05-16 11:47 ` Srivatsa S. Bhat
2014-05-15 8:40 ` Juri Lelli
2014-05-15 8:51 ` Peter Zijlstra
2014-05-15 11:52 ` Juri Lelli
2014-05-16 10:43 ` Peter Zijlstra
2014-05-16 11:01 ` Juri Lelli
2014-05-16 11:04 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515151256.GR30445@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bruce.w.allan@intel.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox