From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: Dave Jones <davej@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: WARN in do_rt_tgsigqueueinfo()
Date: Thu, 15 May 2014 20:04:09 +0200 [thread overview]
Message-ID: <20140515180409.GA5972@redhat.com> (raw)
In-Reply-To: <20140515160950.GA22846@mguzik.redhat.com>
On 05/15, Mateusz Guzik wrote:
>
> On Thu, May 15, 2014 at 11:54:15AM -0400, Dave Jones wrote:
> >
> > I'm of the opinion that a user-triggerable WARN is a bug, but aparently
> > not everyone else feels that way.
I didn't really like this WARN_ONCE() when I looked at the patch which
added it, but I didn't try to argue.
> imho warning sysadmins about userspace using deprecated stuff is fine as
> long as users are not able to spam the console with it.
Agreed,
> Warning reported here just looks scary and provides no information for
> sysadmins so I guess it hould be changed.
Again, agreed.
So imo we should either remove it, ot turn it into
pr_warn_once("something meaningful");
Oleg.
next prev parent reply other threads:[~2014-05-15 18:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 13:38 WARN in do_rt_tgsigqueueinfo() Peter Zijlstra
2014-05-15 14:27 ` Mateusz Guzik
2014-05-15 15:04 ` Peter Zijlstra
2014-05-15 15:54 ` Dave Jones
2014-05-15 15:56 ` Peter Zijlstra
2014-05-15 16:09 ` Mateusz Guzik
2014-05-15 18:04 ` Oleg Nesterov [this message]
2014-05-15 16:46 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515180409.GA5972@redhat.com \
--to=oleg@redhat.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox