public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: rtm <wwctrsrx@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: line6: Add blank lines after declarations
Date: Thu, 15 May 2014 21:41:39 +0300	[thread overview]
Message-ID: <20140515184139.GA28806@gmail.com> (raw)
In-Reply-To: <20140513120201.GA32045@kroah.com>

On Tue, May 13, 2014 at 02:02:01PM +0200, Greg KH wrote:
> On Wed, May 14, 2014 at 02:56:42AM +0300, Artem Fetishev wrote:
> > Use the more common kernel coding style.
> > 
> > Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
> > ---
> >  drivers/staging/line6/capture.c  |    4 ++++
> >  drivers/staging/line6/midi.c     |    2 ++
> >  drivers/staging/line6/playback.c |    5 +++++
> >  drivers/staging/line6/pod.c      |    5 +++++
> >  drivers/staging/line6/toneport.c |    2 ++
> >  drivers/staging/line6/variax.c   |    2 ++
> >  6 files changed, 20 insertions(+)
> > 
> > diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c
> > index 0eda51d..14ed0d7 100644
> > --- a/drivers/staging/line6/capture.c
> > +++ b/drivers/staging/line6/capture.c
> > @@ -97,6 +97,7 @@ void line6_unlink_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> >  		if (test_bit(i, &line6pcm->active_urb_in)) {
> >  			if (!test_and_set_bit(i, &line6pcm->unlink_urb_in)) {
> >  				struct urb *u = line6pcm->urb_audio_in[i];
> > +
> >  				usb_unlink_urb(u);
> >  			}
> >  		}
> > @@ -122,6 +123,7 @@ void line6_wait_clear_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> >  		if (!alive)
> >  			break;
> >  		set_current_state(TASK_UNINTERRUPTIBLE);
> > +
> >  		schedule_timeout(1);
> >  	} while (--timeout > 0);
> >  	if (alive)
> 
> That line doesn't look like it needs to be added, why do so?
> 

I've removed that new line in v2 of the patch. I sent it two days ago.

      reply	other threads:[~2014-05-15  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 23:56 [PATCH] drivers: staging: line6: Add blank lines after declarations Artem Fetishev
2014-05-13 12:02 ` Greg KH
2014-05-15 18:41   ` rtm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515184139.GA28806@gmail.com \
    --to=wwctrsrx@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox