From: Greg KH <gregkh@linuxfoundation.org>
To: Denis Pithon <denis.pithon@gmail.com>
Cc: devel@driverdev.osuosl.org, himangi774@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()
Date: Thu, 15 May 2014 14:57:39 -0700 [thread overview]
Message-ID: <20140515215739.GC4642@kroah.com> (raw)
In-Reply-To: <1399908167-19271-4-git-send-email-denis.pithon@gmail.com>
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
> Fix some coding style issues concerning printk() usage.
>
> Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> index 61a3092..3577d20 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -384,8 +384,9 @@ static int p80211knetdev_hard_start_xmit(struct sk_buff *skb,
> */
> if (skb->protocol != ETH_P_80211_RAW) {
> netif_start_queue(wlandev->netdev);
> - printk(KERN_NOTICE
> - "Tx attempt prior to association, frame dropped.\n");
> + pr_notice(
> + "Tx attempt prior to association, frame dropped\n"
> + );
Can't these be netdev messages, or at the least, dev_* messages?
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-15 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 15:22 [PATCH 1/4] staging/wlan-ng: update function header comment Denis Pithon
2014-05-12 15:22 ` [PATCH 2/4] staging/wlan-ng: remove function declaration Denis Pithon
2014-05-12 15:22 ` [PATCH 3/4] staging/wlan-ng: code refactoring Denis Pithon
2014-05-16 7:26 ` Tobias Klauser
2014-05-16 22:14 ` [PATCH 2/4] staging/wlan-ng: compare using ether_addr_equal_unaligned Denis Pithon
2014-05-16 22:14 ` [PATCH 3/4] staging/wlan-ng: multicast address checking Denis Pithon
2014-05-16 22:14 ` [PATCH 4/4] staging/wlan-ng: rearrange comments Denis Pithon
2014-05-16 22:30 ` [PATCH 1/4] staging/wlan-ng: add prefix to function name Denis Pithon
2014-05-12 15:22 ` [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx() Denis Pithon
2014-05-14 11:57 ` Dan Carpenter
2014-05-15 21:57 ` Greg KH [this message]
2014-05-16 22:24 ` [PATCH] staging/wlan-ng: log with netdev_xxx and dev_xxx Denis Pithon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515215739.GC4642@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=denis.pithon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=himangi774@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox