From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, peterz@infradead.org,
eranian@google.com, namhyung@kernel.org
Subject: Re: mplement lbr-as-callgraph v6
Date: Fri, 16 May 2014 11:52:18 +0200 [thread overview]
Message-ID: <20140516095218.GA19475@krava.brq.redhat.com> (raw)
In-Reply-To: <1399936829-28194-1-git-send-email-andi@firstfloor.org>
On Mon, May 12, 2014 at 04:20:20PM -0700, Andi Kleen wrote:
> [Even more review feedback and some bugs addressed.]
> [Only port to changes in perf/core. No other changes.]
>
> This patchkit implements lbr-as-callgraphs in per freport,
> as an alternative way to present LBR information.
>
> Current perf report does a histogram over the branch edges,
> which is useful to look at basic blocks, but doesn't tell
> you anything about the larger control flow behaviour.
>
> This patchkit adds a new option --branch-history that
> adds the branch paths to the callgraph history instead.
>
> This allows to reason about individual branch paths leading
> to specific samples.
>
> Also available at
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc perf/lbr-callgraph4
>
> v2:
> - rebased on perf/core
> - fix various issues
> - rename the option to --branch-history
> - various fixes to display the information more concise
> v3:
> - White space changes
> - Consolidate some patches
> - Update some descriptions
> v4:
> - Fix various display problems
> - Unknown srcline is now printed as symbol+offset
> - Refactor some code to address review feedback
> - Merge with latest tip
> - Fix missing srcline display in stdio hist output.
> v5:
> - Rename functions
> - Fix gtk build problem
> - Fix crash without -g
> - Improve error messages
> - Improve srcline display in various ways
> v6:
> - Port to latest perf/core
which one? can't apply this on latest tip's perf/core
you branch perf/lbr-callgraph4 is based on:
commit 538592ff0b008237ae88f5ce5fb1247127dc3ce5
Merge: 0afd2d5 a51e87c
Author: Ingo Molnar <mingo@kernel.org>
Date: Wed Mar 19 08:05:47 2014 +0100
jirka
next prev parent reply other threads:[~2014-05-16 9:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 23:20 mplement lbr-as-callgraph v6 Andi Kleen
2014-05-12 23:20 ` [PATCH 1/9] perf, tools: Support handling complete branch stacks as histograms v5 Andi Kleen
2014-05-12 23:20 ` [PATCH 2/9] perf, tools: Add --branch-history option to report v3 Andi Kleen
2014-05-12 23:20 ` [PATCH 3/9] perf, tools: Enable printing the srcline in the history v3 Andi Kleen
2014-05-12 23:20 ` [PATCH 4/9] perf, tools: Only print base source file for srcline Andi Kleen
2014-05-12 23:20 ` [PATCH 5/9] perf, tools: Support source line numbers in annotate Andi Kleen
2014-05-12 23:20 ` [PATCH 6/9] perf, tools: Fix srcline sort key output to use width Andi Kleen
2014-05-12 23:20 ` [PATCH 7/9] tools, perf: Make get_srcline fall back to sym+offset Andi Kleen
2014-05-12 23:20 ` [PATCH 8/9] tools, perf: Make srcline output address with -v Andi Kleen
2014-05-16 9:53 ` Jiri Olsa
2014-05-12 23:20 ` [PATCH 9/9] tools, perf: Add asprintf replacement Andi Kleen
2014-05-16 9:52 ` Jiri Olsa [this message]
2014-05-16 14:34 ` mplement lbr-as-callgraph v6 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516095218.GA19475@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox