From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756371AbaEPN1E (ORCPT ); Fri, 16 May 2014 09:27:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27298 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbaEPN1B (ORCPT ); Fri, 16 May 2014 09:27:01 -0400 Date: Fri, 16 May 2014 09:26:30 -0400 From: Don Zickus To: Jiri Olsa Cc: acme@ghostprotocols.net, peterz@infradead.org, LKML , namhyung@gmail.com, eranian@google.com, Andi Kleen Subject: Re: [PATCH 2/6] Revert "perf: Disable PERF_RECORD_MMAP2 support" Message-ID: <20140516132630.GM50500@redhat.com> References: <1399999697-65875-1-git-send-email-dzickus@redhat.com> <1399999697-65875-3-git-send-email-dzickus@redhat.com> <20140516112514.GC19475@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140516112514.GC19475@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 16, 2014 at 01:25:14PM +0200, Jiri Olsa wrote: > On Tue, May 13, 2014 at 12:48:13PM -0400, Don Zickus wrote: > > SNIP > > > - /* > > - * Anon maps don't have the execname. > > - */ > > - if (n < 4) > > + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n", > > + &event->mmap2.start, &event->mmap2.len, prot, > > + &event->mmap2.pgoff, &event->mmap2.maj, > > + &event->mmap2.min, > > + &ino, execname); > > + > > + event->mmap2.ino = (u64)ino; > > + > > + if (n < 7) > > continue; > > any reason for changing this from 'if (n != 8)' ? Yes, read 9d4ecc8893832337daf241236841db966fa53489. :-) This wasn't a clean revert because of the change for (n != 5) -> (n < 4). So I maintainted the spirit of the upstream code with this revert. Let me know if that is wrong. Cheers, Don