Re: [PATCH 2/6] Revert "perf: Disable PERF_RECORD_MMAP2 support"

Don Zickus
2014-05-16T13:27:04Z

On Fri, May 16, 2014 at 01:25:14PM +0200, Jiri Olsa wrote:
> On Tue, May 13, 2014 at 12:48:13PM -0400, Don Zickus wrote:
>
> SNIP
>
> > - /*
> > - * Anon maps don't have the execname.
> > - */
> > - if (n < 4)
> > + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> > + &event->mmap2.start, &event->mmap2.len, prot,
> > + &event->mmap2.pgoff, &event->mmap2.maj,
> > + &event->mmap2.min,
> > + &ino, execname);
> > +
> > + event->mmap2.ino = (u64)ino;
> > +
> > + if (n < 7)
> > continue;
>
> any reason for changing this from 'if (n != 8)' ?

Yes, read 9d4ecc8893832337daf241236841db966fa53489. :-)

This wasn't a clean revert because of the change for (n != 5) -> (n < 4).
So I maintainted the spirit of the upstream code with this revert. Let me
know if that is wrong.

Cheers,
Don