From: Oleg Nesterov <oleg@redhat.com>
To: Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@elte.hu>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: uprobes && shmem (Was: uprobes: Shift ->readpage check from __copy_insn() to uprobe_register())
Date: Fri, 16 May 2014 17:30:58 +0200 [thread overview]
Message-ID: <20140516153058.GA30667@redhat.com> (raw)
In-Reply-To: <20140516152919.GA30659@redhat.com>
Hi Hugh,
On 05/16, Oleg Nesterov wrote:
>
> copy_insn() fails with -EIO if ->readpage == NULL
In particular, this means that we can not probe the binaries on tmpfs.
This is pity.
It seems that the potential fix is trivial, copy_insn() could use
shmem_getpage_gfp(). But, is there any way to figure out that this
inode/mapping/aops/whatever is actually shmem?
I am looking at shmem_get_inode() and I see nothing which could help,
and shmem_aops/etc are all static.
Oleg.
next parent reply other threads:[~2014-05-16 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140516152919.GA30659@redhat.com>
2014-05-16 15:30 ` Oleg Nesterov [this message]
2014-05-16 18:49 ` uprobes && shmem (Was: uprobes: Shift ->readpage check from __copy_insn() to uprobe_register()) Hugh Dickins
2014-05-16 19:29 ` Oleg Nesterov
2014-05-17 2:07 ` Hugh Dickins
2014-05-17 16:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516153058.GA30667@redhat.com \
--to=oleg@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox