From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758014AbaEPQZZ (ORCPT ); Fri, 16 May 2014 12:25:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29865 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757650AbaEPQZX (ORCPT ); Fri, 16 May 2014 12:25:23 -0400 Date: Fri, 16 May 2014 12:24:41 -0400 From: Don Zickus To: Stephane Eranian Cc: Peter Zijlstra , Arnaldo Carvalho de Melo , LKML , Jiri Olsa , Namhyung Kim , Andi Kleen Subject: Re: [PATCH 6/6] perf: Add dcacheline sort Message-ID: <20140516162441.GA50500@redhat.com> References: <1399999697-65875-1-git-send-email-dzickus@redhat.com> <1399999697-65875-7-git-send-email-dzickus@redhat.com> <20140516155958.GX11096@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 16, 2014 at 06:02:43PM +0200, Stephane Eranian wrote: > On Fri, May 16, 2014 at 5:59 PM, Peter Zijlstra wrote: > > On Fri, May 16, 2014 at 04:09:59PM +0200, Stephane Eranian wrote: > >> > +#define CACHE_LINESIZE 64 > >> I had something similar to your patch here in my original series for > >> perf mem, but I never pushed it. > >> I think this is a useful feature to have. > >> However, I don't think you can hardcode the cache line size to 64. > >> This is generic > >> code. There may be architectures where the line size is different from 64. > >> So I think you should add an option to change the default line size or provide > >> an arch-specific definition. > > > > # cat /sys/devices/system/cpu/cpu0/cache/index0/coherency_line_size > > 64 > Excellent, then we should use that! Would it make sense to create an accessory function that sets the size in util/cpumap.c and provides it as an inline from util/cpumap.h? Cheers, Don