From: Greg KH <gregkh@linuxfoundation.org>
To: Junsu Shin <jsshin.dev@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: gdm72xx: gdm_wimax: Fixed coding style issues.
Date: Fri, 16 May 2014 12:12:30 -0700 [thread overview]
Message-ID: <20140516191230.GA13758@kroah.com> (raw)
In-Reply-To: <1398711011-3834-1-git-send-email-jsshin.dev@gmail.com>
On Mon, Apr 28, 2014 at 01:50:11PM -0500, Junsu Shin wrote:
> Fixed following coding style issues.
> - No space is necessary after a cast
> - Alignment should match open parenthesis
> - Braces {} should be used on all arms of this statement
You are doing 3 things, so this should be 3 patches at the least.
Remember, one patch per "thing".
> Signed-off-by: Junsu Shin <jsshin.dev@gmail.com>x
What is the trailing 'x' for?
thanks,
greg k-h
prev parent reply other threads:[~2014-05-16 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 18:50 [PATCH] Staging: gdm72xx: gdm_wimax: Fixed coding style issues Junsu Shin
2014-05-16 19:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516191230.GA13758@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jsshin.dev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox