From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755991AbaEPVLk (ORCPT ); Fri, 16 May 2014 17:11:40 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:27894 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755320AbaEPVLf (ORCPT ); Fri, 16 May 2014 17:11:35 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18a01JMvKgILjXBhT95VtVH Date: Fri, 16 May 2014 14:11:25 -0700 From: Tony Lindgren To: Aaro Koskinen Cc: Paul Bolle , Kevin Hilman , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP: remove some dead code Message-ID: <20140516211125.GE12881@atomide.com> References: <1400181381.11786.18.camel@x220> <20140515194317.GB4752@drone.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140515194317.GB4752@drone.musicnaut.iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Aaro Koskinen [140515 12:48]: > On Thu, May 15, 2014 at 09:16:21PM +0200, Paul Bolle wrote: > > A check for CONFIG_CBUS_TAHVO_USB was added in v2.6.17. The related > > Kconfig symbol has never been part of the tree. Remove that check. > > > > Replace the while (...) loop with a simple if (...) statement, while > > we're at it. > > > > Signed-off-by: Paul Bolle > > Acked-by: Aaro Koskinen > > > --- > > Untested, as usual. > > > > A quick search across the history of the tree suggests CBUS_TAHVO_USB > > was N770 related. Not that this matters much. > > Yes, Tahvo USB is only used on Nokia 770 (which is the correct name, > not N770). The driver is nowadays behind TAHVO_USB, but like you said > the old symbol was never part of the mainline so it's OK to delete it. Thanks applying into omap-for-v3.16/board. Tony