public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Masood Mehmood <ody.guru@gmail.com>
Subject: Re: [PATCH] Fix for possible null pointer dereference in node.c
Date: Sat, 17 May 2014 21:56:16 +0300	[thread overview]
Message-ID: <20140517185615.GB15585@mwanda> (raw)
In-Reply-To: <CAFo99gYEf6GrAjuWNc5+DEEuBV82eejRuy7QtiJuLD+sRccLRA@mail.gmail.com>

On Sat, May 17, 2014 at 03:21:56PM +0200, Rickard Strandqvist wrote:
> Okay, everyone agrees with Dan..?
> 

You can audit it yourself, there are only 4 callers.  The
node_allocate() is total garbage so the second delete_node() is a bit
complicated to read but it's not that hard.

> I have made a new patch, which does not check if hnode is NULL.

Send it inline so we can use our normal scripts.

regards,
dan carpenter


  reply	other threads:[~2014-05-17 18:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 21:53 [PATCH] Fix for possible null pointer dereference in node.c Rickard Strandqvist
2014-05-15 22:08 ` Greg Kroah-Hartman
2014-05-15 22:14   ` Rickard Strandqvist
2014-05-15 22:43 ` Dan Carpenter
2014-05-17 13:21   ` Rickard Strandqvist
2014-05-17 18:56     ` Dan Carpenter [this message]
2014-05-18 15:49       ` Rickard Strandqvist
2014-05-18 16:22         ` Dan Carpenter
2014-05-18 17:14           ` Rickard Strandqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140517185615.GB15585@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ody.guru@gmail.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox