From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Martin Kepplinger <martink@posteo.de>,
gregkh@linuxfoundation.org,
Devin Heitmueller <dheitmueller@kernellabs.com>,
devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, m.chehab@samsung.com
Subject: Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()
Date: Sat, 17 May 2014 22:22:53 +0300 [thread overview]
Message-ID: <20140517192253.GC15585@mwanda> (raw)
In-Reply-To: <53779A7F.8020007@iki.fi>
On Sat, May 17, 2014 at 08:21:03PM +0300, Antti Palosaari wrote:
> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
> >don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
> >use the common kernel coding style.
> >
> >Signed-off-by: Martin Kepplinger <martink@posteo.de>
>
> Reviewed-by: Antti Palosaari <crope@iki.fi>
>
> >---
> >this applies to next-20140516. any more suggestions?
> >more cleanup can be done when dprintk() is completely gone.
>
> Do you have the device? I am a bit reluctant patching that driver
> without any testing as it has happened too many times something has
> gone totally broken.
Looking through the log the only time I see breakage is build breakage
on allyesconfig.
1ec9a35 [media] staging: as102: Add missing function argument
This was a compile warning and it definitely should have been caught
before the code was submitted or merged, but it wasn't something people
would hit in real life.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-17 19:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 13:16 [PATCH] staging: media: as102: replace custom dprintk() with dev_dbg() Martin Kepplinger
2014-05-17 13:59 ` Antti Palosaari
2014-05-17 16:05 ` [PATCHv2] " Martin Kepplinger
2014-05-17 17:21 ` Antti Palosaari
2014-05-17 17:52 ` Martin Kepplinger
2014-05-17 18:43 ` Gianluca Gennari
2014-05-17 19:22 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-04 9:10 [PATCH] " Dan Carpenter
2014-08-04 10:17 ` [PATCHv2] " Martin Kepplinger
2014-08-04 10:40 ` Dan Carpenter
2014-08-04 11:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517192253.GC15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crope@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=dheitmueller@kernellabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox