From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbaEQTZS (ORCPT ); Sat, 17 May 2014 15:25:18 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25317 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbaEQTZR (ORCPT ); Sat, 17 May 2014 15:25:17 -0400 Date: Sat, 17 May 2014 22:24:50 +0300 From: Dan Carpenter To: Christian Engelmayer Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Jes.Sorensen@redhat.com, Larry.Finger@lwfinger.net Subject: Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init() Message-ID: <20140517192450.GF16255@mwanda> References: <1400323138-32243-1-git-send-email-cengelma@gmx.at> <1400323138-32243-2-git-send-email-cengelma@gmx.at> <20140517144423.GA15585@mwanda> <20140517205635.22c40685@spike> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140517205635.22c40685@spike> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 17, 2014 at 08:56:35PM +0200, Christian Engelmayer wrote: > On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter wrote: > > On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: > > > Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS > > > as long as not explicitly set. Thus initialize 'status' to FAIL, in order to > > > prevent undefined behaviour if going through the exit paths. Detected by > > > Coverity - CID 1077832. > > > > > > Signed-off-by: Christian Engelmayer > > > > This is a bugfix and we like to merge bugfixes without asking redo > > things, so don't redo. But really the better fix is to get rid of the > > status variable completely. Just return directly on the success path. > > > > If we were to do that, then both patches would be merged together and > > called: [patch] Staging: rtl8188eu: fix error handling in rtw_drv_init() > > > > But this patch is also acceptable as-is. Thanks for fixing the bug. :) > > I agree with You Dan. I'm no big fan of that status variable either. In this > case I was already tempted, but saw it as a recurring pattern in that file > in case cleanup is done. So I decided to just attack the bug in a small change > and leave the cleanup of the error handling pattern for a later, consistent > sweep over the whole file if that's wanted. It's a mistake to try be consistent with the crap code in the rest of this file. ;) Next time just fix it so at least a couple lines in here are not terrible. regards, dan carpenter