From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbaEQUXr (ORCPT ); Sat, 17 May 2014 16:23:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30627 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbaEQUXq (ORCPT ); Sat, 17 May 2014 16:23:46 -0400 Date: Sat, 17 May 2014 23:22:55 +0300 From: Dan Carpenter To: Peter Senna Tschudin Cc: Dominik Brodowski , Thomas Renninger , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Alan Cox , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/4] cpupower: Remove redundant error check Message-ID: <20140517202255.GF15585@mwanda> References: <1400350980-30455-2-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400350980-30455-2-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote: > diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c > index a416de8..4e2f35a 100644 > --- a/tools/power/cpupower/utils/cpufreq-set.c > +++ b/tools/power/cpupower/utils/cpufreq-set.c > @@ -320,12 +320,11 @@ int cmd_freq_set(int argc, char **argv) > > printf(_("Setting cpu: %d\n"), cpu); > ret = do_one_cpu(cpu, &new_pol, freq, policychange); > - if (ret) > + if (ret) { > + print_error(); > break; Just return directly instead of break return; > + } > } > > - if (ret) > - print_error(); > - > return ret; Are you sure this patch is correct? Theoretically, it's possible to reach the end of this function without going hitting the "ret = do_one_cpu(...);" assignment. Don't be fooled by the "int ret = 0;" initialization, that is a trick initialization to mislead the unwary. By the end of the do while loop then "ret" is always -1. regards, dan carpenter