From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/4] IB: Remove redundant error check
Date: Sat, 17 May 2014 23:25:58 +0300 [thread overview]
Message-ID: <20140517202558.GG15585@mwanda> (raw)
In-Reply-To: <1400350980-30455-4-git-send-email-peter.senna@gmail.com>
On Sat, May 17, 2014 at 08:23:00PM +0200, Peter Senna Tschudin wrote:
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 +++---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> index 3bbf201..f085a51 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> @@ -1839,11 +1839,11 @@ int ocrdma_reg_mr(struct ocrdma_dev *dev,
>
> status = ocrdma_mbx_reg_mr_cont(dev, hwmr, cur_pbl_cnt,
> pbl_offset, last);
> - if (status)
> + if (status) {
> + pr_err("%s() err. status=%d\n", __func__, status);
> break;
return status;
> + }
> }
> - if (status)
> - pr_err("%s() err. status=%d\n", __func__, status);
>
> return status;
return 0;
> }
regards,
dan carpenter
prev parent reply other threads:[~2014-05-17 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 18:23 [PATCH 4/4] IB: Remove redundant error check Peter Senna Tschudin
2014-05-17 20:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517202558.GG15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox