* [PATCH] staging: tidspbridge: rmgr: node.c: Fix for possible null pointer dereference
@ 2014-05-18 15:56 Rickard Strandqvist
2014-05-18 16:02 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-05-18 15:56 UTC (permalink / raw)
To: Omar Ramirez Luna, Greg Kroah-Hartman
Cc: Rickard Strandqvist, Masood Mehmood, Dan Carpenter, devel,
linux-kernel
Removde unnecessary check for null pointer.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/tidspbridge/rmgr/node.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/node.c b/drivers/staging/tidspbridge/rmgr/node.c
index 9d3044a..d918f7f 100644
--- a/drivers/staging/tidspbridge/rmgr/node.c
+++ b/drivers/staging/tidspbridge/rmgr/node.c
@@ -2365,8 +2365,6 @@ static void delete_node(struct node_object *hnode,
(struct proc_object *)hnode->processor;
#endif
int status;
- if (!hnode)
- goto func_end;
hnode_mgr = hnode->node_mgr;
if (!hnode_mgr)
goto func_end;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: tidspbridge: rmgr: node.c: Fix for possible null pointer dereference
2014-05-18 15:56 [PATCH] staging: tidspbridge: rmgr: node.c: Fix for possible null pointer dereference Rickard Strandqvist
@ 2014-05-18 16:02 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-05-18 16:02 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Omar Ramirez Luna, Greg Kroah-Hartman, devel, linux-kernel,
Masood Mehmood
Sorry, I should have noticed this before, but the subject doesn't match
the patch any more.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-18 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-18 15:56 [PATCH] staging: tidspbridge: rmgr: node.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-05-18 16:02 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox