From: Borislav Petkov <bp@alien8.de>
To: Chen Yucong <slaoub@gmail.com>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU
Date: Mon, 19 May 2014 09:26:19 +0200 [thread overview]
Message-ID: <20140519072619.GA6311@pd.tnic> (raw)
In-Reply-To: <1400464540.9630.31.camel@debian>
On Mon, May 19, 2014 at 09:55:40AM +0800, Chen Yucong wrote:
> But all other CPUs also have to wait monarch CPU to exit from mce_end.
> What's the difference between monarch CPU and Per-CPU for clearing
> mces_seen? In practice, there is no difference between them. If we use
> monarch CPU to clear mces_seen, then Per-CPU variable can not play out
> its advantage.
I'll let you stare at mce_reign() a little bit longer... Also, pay
attention to its callsite, that might help.
> Well, in that case, why is there a need for time-out machine in MCE
> handler?
I'll let you figure this out yourself too - it is only fair.
:-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-05-19 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 15:05 [PATCH] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU Chen Yucong
2014-05-18 16:35 ` Borislav Petkov
2014-05-19 1:55 ` Chen Yucong
2014-05-19 7:26 ` Borislav Petkov [this message]
2014-05-19 7:54 ` Chen Yucong
2014-05-19 8:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519072619.GA6311@pd.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slaoub@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox