From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbaESHrM (ORCPT ); Mon, 19 May 2014 03:47:12 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:54340 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbaESHrL (ORCPT ); Mon, 19 May 2014 03:47:11 -0400 Date: Mon, 19 May 2014 08:47:05 +0100 From: Lee Jones To: Hans de Goede Cc: Mark Brown , Charles Keepax , Samuel Ortiz , Liam Girdwood , Carlo Caione , Maxime Ripard , Linux Kernel Mailing List , linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases() Message-ID: <20140519074705.GE2339@lee--X1> References: <1400420953-20705-1-git-send-email-hdegoede@redhat.com> <1400420953-20705-2-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1400420953-20705-2-git-send-email-hdegoede@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We cannot register supply alias in mfd_add_device before calling > platform_add_device, for 2 reasons: > 1) devm resources may not be registered before the (platform) drivers probe > method runs > 2) The platform-dev's name must be set before registering the aliases which > happens from platform_add_device. > > So stop registering supply aliases from mfd_add_device, and add a > mfd_register_supply_aliases helper functions for the cell's plaform driver > probe method to use. > > Signed-off-by: Hans de Goede > --- > drivers/mfd/mfd-core.c | 37 +++++++++++++++++++++---------------- > include/linux/mfd/core.h | 6 +++++- > 2 files changed, 26 insertions(+), 17 deletions(-) Change looks reasonable to me, but I'd like to have Mark look over the changes. If he's okay with them I think it's best for this set to go through the MFD tree as a whole. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog