From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Brown <broonie@linaro.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Carlo Caione <carlo@caione.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()
Date: Mon, 19 May 2014 08:48:38 +0100 [thread overview]
Message-ID: <20140519074838.GF2339@lee--X1> (raw)
In-Reply-To: <20140519074705.GE2339@lee--X1>
> > We cannot register supply alias in mfd_add_device before calling
> > platform_add_device, for 2 reasons:
> > 1) devm resources may not be registered before the (platform) drivers probe
> > method runs
> > 2) The platform-dev's name must be set before registering the aliases which
> > happens from platform_add_device.
> >
> > So stop registering supply aliases from mfd_add_device, and add a
> > mfd_register_supply_aliases helper functions for the cell's plaform driver
> > probe method to use.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > drivers/mfd/mfd-core.c | 37 +++++++++++++++++++++----------------
> > include/linux/mfd/core.h | 6 +++++-
> > 2 files changed, 26 insertions(+), 17 deletions(-)
>
> Change looks reasonable to me, but I'd like to have Mark look over the
> changes. If he's okay with them I think it's best for this set to go
> through the MFD tree as a whole.
For my own benefit, rather than a go-ahead for Mark to apply them: ;)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-19 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 13:49 [PATCH 0/3] Fix WARN_ON caused by "mfd: Allow mapping regulator supplies to MFD device from children" Hans de Goede
2014-05-18 13:49 ` [PATCH 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases() Hans de Goede
2014-05-19 7:47 ` Lee Jones
2014-05-19 7:48 ` Lee Jones [this message]
2014-05-19 7:48 ` Charles Keepax
2014-05-19 8:18 ` Hans de Goede
2014-05-19 8:28 ` Charles Keepax
2014-05-19 9:11 ` Lee Jones
2014-05-18 13:49 ` [PATCH 2/3] regulator/axp20x: Call mfd_register_supply_aliases Hans de Goede
2014-05-18 13:49 ` [PATCH 3/3] arizona-mfd-codecs: Add mfd_register_supply_aliases() calls Hans de Goede
2014-05-19 8:29 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519074838.GF2339@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@linaro.org \
--cc=carlo@caione.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox