From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbaESHtA (ORCPT ); Mon, 19 May 2014 03:49:00 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:43018 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbaESHs7 (ORCPT ); Mon, 19 May 2014 03:48:59 -0400 Date: Mon, 19 May 2014 08:48:55 +0100 From: Charles Keepax To: Lee Jones Cc: Hans de Goede , Mark Brown , Samuel Ortiz , Liam Girdwood , Carlo Caione , Maxime Ripard , Linux Kernel Mailing List , linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases() Message-ID: <20140519074855.GP25203@opensource.wolfsonmicro.com> References: <1400420953-20705-1-git-send-email-hdegoede@redhat.com> <1400420953-20705-2-git-send-email-hdegoede@redhat.com> <20140519074705.GE2339@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140519074705.GE2339@lee--X1> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 19, 2014 at 08:47:05AM +0100, Lee Jones wrote: > > We cannot register supply alias in mfd_add_device before calling > > platform_add_device, for 2 reasons: > > 1) devm resources may not be registered before the (platform) drivers probe > > method runs > > 2) The platform-dev's name must be set before registering the aliases which > > happens from platform_add_device. > > > > So stop registering supply aliases from mfd_add_device, and add a > > mfd_register_supply_aliases helper functions for the cell's plaform driver > > probe method to use. > > > > Signed-off-by: Hans de Goede > > --- > > drivers/mfd/mfd-core.c | 37 +++++++++++++++++++++---------------- > > include/linux/mfd/core.h | 6 +++++- > > 2 files changed, 26 insertions(+), 17 deletions(-) > > Change looks reasonable to me, but I'd like to have Mark look over the > changes. If he's okay with them I think it's best for this set to go > through the MFD tree as a whole. This should already be fixed by this patch: mfd: core: Don't use devres functions before device is added You had posted to say it was applied although I haven't checked your tree for it directly. Thanks, Charles