From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Saraev <antonysaraev@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, jason@lakedaemon.net, jake@lwn.net
Subject: Re: [PATCH v2 05/06] staging: crypto: skein: rename macros
Date: Mon, 19 May 2014 12:08:39 +0300 [thread overview]
Message-ID: <20140519090839.GR15585@mwanda> (raw)
In-Reply-To: <2eac124c6a3815c72e91679c8cde729af712bb74.1399675445.git.antonysaraev@gmail.com>
On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote:
> +/* ignore all asserts, for performance */
> +#define skein_assert_ret(x, ret_code)
> +#define skein_assert(x)
Not related to this patch, but defining away asserts like this is a bad
idea. What if they have side affects like:
skein_assert(foo++ == bar);
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-19 9:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:09 [PATCH v2 00/06] staging: crypto: skein: fixing style issues Anton Saraev
2014-05-19 8:09 ` [PATCH v2 01/06] staging: crypto: skein: rename camelcase functions Anton Saraev
2014-05-19 8:09 ` [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars Anton Saraev
2014-05-19 9:02 ` Dan Carpenter
2014-05-19 14:40 ` Jake Edge
2014-05-19 19:21 ` Dan Carpenter
2014-05-19 19:44 ` Jake Edge
2014-05-19 19:55 ` Dan Carpenter
2014-05-19 8:09 ` [PATCH v2 03/06] staging: crypto: skein: rename skein1024_ctx to skein_1024_ctx Anton Saraev
2014-05-19 8:09 ` [PATCH v2 04/06] staging: crypto: skein: rename enums Anton Saraev
2014-05-19 8:09 ` [PATCH v2 05/06] staging: crypto: skein: rename macros Anton Saraev
2014-05-19 9:08 ` Dan Carpenter [this message]
2014-05-19 14:04 ` Jason Cooper
2014-05-19 8:09 ` [PATCH v2 06/06] staging: crypto: skein: rename files Anton Saraev
2014-05-19 13:29 ` Jake Edge
2014-05-19 14:05 ` Jason Cooper
2014-05-19 13:45 ` Jake Edge
2014-05-19 22:22 ` Greg KH
2014-05-19 8:53 ` [PATCH v2 00/06] staging: crypto: skein: fixing style issues Dan Carpenter
2014-05-19 14:11 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519090839.GR15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=antonysaraev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jake@lwn.net \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox