From: Rodrigo Campos <rodrigo@sdfg.com.ar>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Arun Sharma <asharma@fb.com>
Subject: Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9)
Date: Mon, 19 May 2014 16:11:20 +0100 [thread overview]
Message-ID: <20140519151120.GE24333@sdfg.com.ar> (raw)
In-Reply-To: <1395293806-25847-1-git-send-email-namhyung@kernel.org>
On Thu, Mar 20, 2014 at 02:36:25PM +0900, Namhyung Kim wrote:
> Hello,
>
> This is a new attempt to implement cumulative hist period report.
> This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely
> rewrote it from scratch.
>
> This version depends on my previous percentage patchset [2] and output
> field patchset[3]. So please test this again although there's not
> much change in the series itself.
>
> This patchset basically adds period in a sample to every node in the
> callchain. A hist_entry now has an additional fields to keep the
> cumulative period if --children option is given on perf report.
>
> I changed the option as a separate --children and added a new
> "Children" column (and renamed the default "Overhead" column into
> "Self"). The output will be sorted by children (cumulative) overhead
> for now. It also adds 'overhead_children' field to -F/--fields option
> to be selected by user and it'll show you "N/A" if the cumulation is
> not supported (due to missing callchain).
Is there something I can help to have this merged ? As far as I tested, this
works fine here. Or is this ok, just waiting on the "perf report: Add -F option for
specifying output fields" patchset ?
Thanks a lot,
Rodrigo
next prev parent reply other threads:[~2014-05-19 15:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 5:36 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9) Namhyung Kim
2014-03-20 5:36 ` [PATCH 01/21] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-03-20 5:36 ` [PATCH 02/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-03-20 5:36 ` [PATCH 03/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-03-20 5:36 ` [PATCH 04/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-03-20 5:36 ` [PATCH 05/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-03-20 5:36 ` [PATCH 06/21] perf report: Cache cumulative callchains Namhyung Kim
2014-03-20 5:36 ` [PATCH 07/21] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-03-20 5:36 ` [PATCH 08/21] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-03-20 5:36 ` [PATCH 09/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-03-20 5:36 ` [PATCH 10/21] perf ui/browser: " Namhyung Kim
2014-03-20 5:36 ` [PATCH 11/21] perf ui/gtk: " Namhyung Kim
2014-03-20 5:36 ` [PATCH 12/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-03-20 5:36 ` [PATCH 13/21] perf tools: Add more hpp helper functions Namhyung Kim
2014-03-20 5:36 ` [PATCH 14/21] perf report: Add --children option Namhyung Kim
2014-03-20 5:36 ` [PATCH 15/21] perf report: Add report.children config option Namhyung Kim
2014-03-20 5:36 ` [PATCH 16/21] perf tools: Do not auto-remove Children column if --fields given Namhyung Kim
2014-03-20 5:36 ` [PATCH 17/21] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-03-20 5:36 ` [PATCH 18/21] perf top: Convert " Namhyung Kim
2014-03-20 5:36 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2014-03-20 5:36 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2014-03-20 5:36 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-03-31 14:26 ` [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9) Arun Sharma
2014-04-01 7:28 ` Namhyung Kim
2014-04-01 7:35 ` Arun Sharma
2014-05-19 15:11 ` Rodrigo Campos [this message]
2014-05-20 2:29 ` Namhyung Kim
2014-05-20 3:06 ` Rodrigo Campos
2014-05-20 7:35 ` Jiri Olsa
2014-05-20 12:00 ` Rodrigo Campos
2014-05-20 14:01 ` Jiri Olsa
2014-05-20 15:52 ` Rodrigo Campos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519151120.GE24333@sdfg.com.ar \
--to=rodrigo@sdfg.com.ar \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox