From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker
Date: Mon, 19 May 2014 17:18:24 +0200 [thread overview]
Message-ID: <20140519151824.GA21762@lst.de> (raw)
In-Reply-To: <1400511950-18522-1-git-send-email-tom.leiming@gmail.com>
On Mon, May 19, 2014 at 11:05:50PM +0800, Ming Lei wrote:
> Another simple fix is to disable ipi for flush request, but looks
> this one should be better.
I think the first thing is to bite the bullet and sort out and document
the various unions in struct request for real.
For example the first union has the call_single_data for the blk-mq
completions, while the second one has the ipi_list that is used by
the old blk-softirq code.
If we get this right with a single union that contains a struct for
each phase of the request we might find enough space to keep using
the current way.
next prev parent reply other threads:[~2014-05-19 15:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:05 [PATCH] block: mq flush: fix race between IPI handler and mq flush worker Ming Lei
2014-05-19 15:18 ` Christoph Hellwig [this message]
2014-05-19 15:34 ` Ming Lei
2014-05-20 3:20 ` Ming Lei
2014-05-20 15:23 ` Christoph Hellwig
2014-05-21 5:16 ` Ming Lei
2014-05-21 5:36 ` Christoph Hellwig
2014-05-21 6:48 ` Ming Lei
2014-05-27 18:13 ` Christoph Hellwig
2014-05-27 18:38 ` Jens Axboe
2014-05-27 18:53 ` Christoph Hellwig
2014-05-27 18:54 ` Jens Axboe
2014-05-27 19:15 ` Christoph Hellwig
2014-05-27 19:17 ` Jens Axboe
2014-05-27 19:21 ` Christoph Hellwig
2014-05-27 19:35 ` Jens Axboe
2014-05-28 1:34 ` Ming Lei
2014-05-28 2:26 ` Jens Axboe
2014-05-28 2:31 ` Jens Axboe
2014-05-28 5:22 ` Christoph Hellwig
2014-05-28 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519151824.GA21762@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).